Remove generic definitions of vectorplot! etc.#96
Merged
Conversation
They introduced dispatching ambiguities. Missing methods will throw an error anyway.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the generic “missing implementation” fallback methods for various plot! functions—letting Julia’s dispatch automatically throw a MethodError—and tightens the vectorplot! signatures by explicitly typing the ptype parameter.
- Removed generic fallback definitions for
gridplot!,scalarplot!,vectorplot!, andstreamplot! - Updated
vectorplot!method signatures to requireptype::Type{T}with awhereconstraint
Comments suppressed due to low confidence (3)
src/dispatch.jl:722
- [nitpick] The parameter name
ptypeis ambiguous; consider renaming it toplotter_typefor better readability and consistency.
function vectorplot!(ctx, ptype::Type{T}, ::Type{Val{1}}, grid, func::Matrix) where {T <: AbstractPlotterType}
src/dispatch.jl:725
- [nitpick] Similarly, rename
ptypetoplotter_typehere to match the updated signature and improve clarity.
function vectorplot!(ctx, ptype::Type{T}, ::Type{Val{1}}, grid, func::Vector) where {T <: AbstractPlotterType}
src/dispatch.jl:410
- Since the generic fallback definitions were removed, add tests to verify that invoking
gridplot!,scalarplot!,vectorplot!, andstreamplot!without concrete implementations correctly raises aMethodError.
###################################################################################
thanks @copilot for the nitpick...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They introduced dispatching ambiguities. Missing methods will throw an error anyway.