Jm/eslint formatting docs#614
Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JonathanMatthey
force-pushed
the
jm/eslint-formatting-docs
branch
from
ade0295 to
f5bf059
Compare
JonathanMatthey
force-pushed
the
jm/eslint-formatting-docs
branch
from
5538b26 to
23e532a
Compare
Anca2022
left a comment
Anca2022
left a comment
There was a problem hiding this comment.
One last thing: WM doesn't have a PR template like the rest of the repos; can you please add one in? 😇
| "preview": "astro preview", | ||
| "astro": "astro" | ||
| "astro": "astro", | ||
| "lint": "eslint .", |
There was a problem hiding this comment.
let's keep this consistent with the rest of the docs repos
format : Format code and fix linting issues
lint : Check code formatting and linting |
| | `bun run build` | Build your production site to `./dist/` | | ||
| | `bun run preview` | Preview your build locally before deploying | | ||
| | `bun run lint` | Check code for linting errors | | ||
| | `bun run lint:fix` | Automatically fix linting errors where possible | |
There was a problem hiding this comment.
Same here - format and lint for consistency
| run: bun install | ||
|
|
||
| - name: Check code quality | ||
| run: bun run check |
There was a problem hiding this comment.
After making the changes in package.json, this command should become bun run lint
| "starlight-links-validator": "^0.17.0", | ||
| "typescript": "^5.8.3" | ||
| }, | ||
| "devDependencies": { |
There was a problem hiding this comment.
This repo doesn't have Biome, like the rest of docs repos, and doesn't format .astro files
|
|
||
| ```sh | ||
| bun run lint:fix | ||
| ``` |
There was a problem hiding this comment.
Same here - format and lint for consistency
|
|
||
| You can substitute the bun commands with your chosen package manager's commands. | ||
|
|
||
| Before submitting a PR, make sure your code passes linting by running `bun run lint`. If there are any issues that can be automatically fixed, use `bun run lint:fix`. |
There was a problem hiding this comment.
| Before submitting a PR, make sure your code passes linting by running `bun run lint`. If there are any issues that can be automatically fixed, use `bun run lint:fix`. | |
| Before submitting a PR, make sure your code passes linting by running `bun run lint`. If there are any issues that can be automatically fixed, use `bun run format`. |
|
Final-final: please mention Biome in the README file, alongside eslint and prettier |
2 participants
Changes
tags breaking up ordered lists within components