-
Notifications
You must be signed in to change notification settings - Fork 163
chore(spec/flows): editorial changes #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meyerweb
wants to merge
6
commits into
WICG:main
Choose a base branch
from
meyerweb:flows-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6bb054
Change MonetizationCurrencyAmount per issue #440
meyerweb 458c394
Change MonetizationCurrencyAmount per issue #440
meyerweb 3f79ea1
Merge branch 'main' into main
meyerweb 2e32312
Update specification/index.html
meyerweb 18e69d2
Typo corrections, clarifications in Flows specification
meyerweb 5d425d9
Merge branch 'main' into flows-spec
meyerweb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,7 @@ <h2>Terms</h2> | |||||
|
|
||||||
| <dt><dfn>Grants</dfn></dt> | ||||||
| <dd> | ||||||
| A delegation of authorization from a resource owner to a client, allowing the client to access protected resources or perform actions on the owner’s behalf. In Rafiki, this process is managed by the authorization server, which issues grants as access tokens. These grants permit clients to interact with Open Payments APIs to, for example, create payments and retrieve account information, based on the permissions granted by the resource owner. | ||||||
| As per GNAP, a delegation of authorization from a resource owner to a client, allowing the client to access protected resources or perform actions on the owner’s behalf. In Rafiki, this process is managed by the authorization server, which issues grants as access tokens. These grants permit clients to interact with Open Payments APIs to, for example, create payments and retrieve account information, based on the permissions granted by the resource owner. | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| </dd> | ||||||
| <dt><dfn>Web monetized website</dfn></dt> | ||||||
| <dd>Describes a page/site that has implemented Web Monetization.</dd> | ||||||
|
|
@@ -44,7 +44,7 @@ <h2>Terms</h2> | |||||
| </dd> | ||||||
|
|
||||||
| <dt><dfn>Wallet</dfn></dt> | ||||||
| <dd>An account within the [=web monetization provider=] or [=web monetization receiver=].</dd> | ||||||
| <dd>An account within a [=web monetization provider=] or [=web monetization receiver=].</dd> | ||||||
|
|
||||||
| <dt><dfn>Wallet address</dfn></dt> | ||||||
| <dd> | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -582,10 +582,20 @@ <h2> | |
| <dfn>currency</dfn> member | ||
| </h2> | ||
| <p> | ||
| The currency of the MonetizationCurrencyAmount. See the definition of | ||
| the `currency` member of {{PaymentCurrencyAmount}} in | ||
| The currency of the MonetizationCurrencyAmount. The default is an | ||
| ISO 4217 three-letter alphabetic code; see the definition of the | ||
| `currency` member of {{PaymentCurrencyAmount}} in | ||
| [[payment-request]] for details. | ||
| </p> | ||
| <aside class="note" title="Divergence from the Payment Request API"> | ||
| <p> | ||
| This member’s definition is left as a generic string to maximize | ||
| flexibility; for example, if a new currency representation | ||
| standard emerges to supplement or replace ISO 4217. This also | ||
| permits Web Monetization implementors to support the numeric | ||
| ISO 4217 codes (as string equivalents) where needed. | ||
| </p> | ||
| </aside> | ||
|
Comment on lines
+590
to
+598
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's avoid these changes until we finalize in #440. |
||
| </section> | ||
| <section> | ||
| <h2> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change feels little odd..