Conversation
✅ Deploy Preview for webmonetization-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
meyerweb
reviewed
May 1, 2026
meyerweb
reviewed
May 1, 2026
meyerweb
reviewed
May 1, 2026
meyerweb
reviewed
May 1, 2026
Contributor
meyerweb
left a comment
meyerweb
left a comment
There was a problem hiding this comment.
Some thoughts on first read.
sidvishnoi
reviewed
May 2, 2026
| dictionary MonetizationInfo { | ||
| dictionary Wallet { | ||
| required DOMString address; | ||
| required DOMString name; |
Collaborator
There was a problem hiding this comment.
In Open Payments, the publicName field is optional.
Collaborator
There was a problem hiding this comment.
Maybe name will be empty string in those cases?
Comment on lines
+70
to
+71
| <code>true</code> when the stored access token is invalid and the | ||
| wallet must be reconnected. |
Collaborator
There was a problem hiding this comment.
What happens when remaining budget is too low? Do we set needsReconnect then as well?
Member
Author
There was a problem hiding this comment.
nothing right now I suspect, needsReconnect is set on the user wallet response, current implementation doesn't guess about reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.