Rename pingEndpointService to cRaterPingService

Author: hirokiterashima

src/main/java/org/wise/vle/web/CRaterController.java

@@ -42,9 +42,9 @@ public class CRaterController {
 
   @Autowired
   private CRaterService cRaterService;
-    
+
   @Autowired
-  private CRaterPingService pingEndpointService;
+  private CRaterPingService cRaterPingService;
 
   @GetMapping("/verify")
   String verifyItemId(CRaterVerificationRequest request) throws JSONException {
@@ -59,8 +59,8 @@ String scoreItem(@RequestBody CRaterScoringRequest request) throws JSONException
   @PostMapping("/ping")
   public String pingItem(@RequestBody CRaterPingRequest ping) throws JSONException {
     String itemId = ping.getItemId();
-    if (!this.pingEndpointService.hasPingedItem(itemId)) {
-      this.pingEndpointService.cachePingedItem(itemId, 280);
+    if (!this.cRaterPingService.hasPingedItem(itemId)) {
+      this.cRaterPingService.cachePingedItem(itemId, 280);
       return this.cRaterService.getCRaterResponse(ping);
     }
     return "";

src/test/java/org/wise/portal/service/ping/impl/CRaterPingServiceImplTest.java

@@ -18,7 +18,7 @@
 @ExtendWith(EasyMockExtension.class)
 public class CRaterPingServiceImplTest {
   @TestSubject
-  private CRaterPingServiceImpl pingEndpointServiceImpl = new CRaterPingServiceImpl();
+  private CRaterPingServiceImpl cRaterPingServiceImpl = new CRaterPingServiceImpl();
 
   @Mock
   private StringRedisTemplate stringRedisTemplate;
@@ -33,7 +33,7 @@ public void hasPingedItem_ItemPinged_ShouldReturnTrue() {
     expect(stringRedisTemplate.opsForValue()).andReturn(valueOperations);
     expect(valueOperations.size(testId)).andReturn(1L);
     replay(stringRedisTemplate, valueOperations);
-    assertTrue(pingEndpointServiceImpl.hasPingedItem(testId));
+    assertTrue(cRaterPingServiceImpl.hasPingedItem(testId));
     verify(stringRedisTemplate);
     verify(valueOperations);
   }
@@ -43,7 +43,7 @@ public void hasPingedItem_ItemNotPinged_ShouldReturnFalse() {
     expect(stringRedisTemplate.opsForValue()).andReturn(valueOperations);
     expect(valueOperations.size(testId)).andReturn(0L);
     replay(stringRedisTemplate, valueOperations);
-    assertFalse(pingEndpointServiceImpl.hasPingedItem(testId));
+    assertFalse(cRaterPingServiceImpl.hasPingedItem(testId));
     verify(stringRedisTemplate);
     verify(valueOperations);
 
@@ -55,7 +55,7 @@ public void cachePingedItem_ShouldCacheAndExpireItemId() {
     expect(stringRedisTemplate.expire(testId, Duration.ofSeconds(1))).andReturn(null);
     expect(valueOperations.setIfAbsent(testId, "pinged")).andReturn(null);
     replay(stringRedisTemplate, valueOperations);
-    pingEndpointServiceImpl.cachePingedItem(testId, 1);
+    cRaterPingServiceImpl.cachePingedItem(testId, 1);
     verify(stringRedisTemplate, valueOperations);
   }
 }

src/test/java/org/wise/vle/web/CRaterControllerTest.java

@@ -27,7 +27,7 @@ public class CRaterControllerTest {
   private CRaterService cRaterService;
 
   @Mock
-  private CRaterPingService pingEndpointService;
+  private CRaterPingService cRaterPingService;
 
   private String clientId = "wise-test";
   private String itemId = "test-item-id";
@@ -94,12 +94,11 @@ public void pingItem_ItemAlreadyPinged_ShouldReturnEmpty() {
     CRaterPingRequest request = new CRaterPingRequest();
     request.setItemId(berkeleyItemId);
     try {
-      expect(pingEndpointService.hasPingedItem(berkeleyItemId))
-        .andReturn(true);
-      replay(cRaterService, pingEndpointService);
+      expect(cRaterPingService.hasPingedItem(berkeleyItemId)).andReturn(true);
+      replay(cRaterService, cRaterPingService);
       String response = controller.pingItem(request);
       assertEquals(response, "");
-      verify(cRaterService, pingEndpointService);
+      verify(cRaterService, cRaterPingService);
     } catch (JSONException exception) {
 
     }
@@ -111,20 +110,19 @@ public void pingItem_ItemNotPinged_ShouldReturnString() {
     request.setItemId(berkeleyItemId);
     try {
       expect(cRaterService.getCRaterResponse(request))
-        .andReturn(createPingResponseString(berkeleyItemId, trackingId, clientId));
-      expect(pingEndpointService.hasPingedItem(berkeleyItemId))
-        .andReturn(false);
-      pingEndpointService.cachePingedItem(berkeleyItemId, 280);
+          .andReturn(createPingResponseString(berkeleyItemId, trackingId, clientId));
+      expect(cRaterPingService.hasPingedItem(berkeleyItemId)).andReturn(false);
+      cRaterPingService.cachePingedItem(berkeleyItemId, 280);
       expectLastCall();
-      replay(cRaterService, pingEndpointService);
+      replay(cRaterService, cRaterPingService);
       String response = controller.pingItem(request);
       assertNotNull(response);
       assertNotEquals(response, "");
-      verify(cRaterService, pingEndpointService);
+      verify(cRaterService, cRaterPingService);
     } catch (JSONException exception) {
 
     }
-    
+
   }
 
   private String createPingResponseString(String itemId, Long trackingId, String clientId) {