Change password from null to random string. Set firstname to be more random so we can generate unique usernames more often. Set locale, last login time and language.

Author: hirokiterashima

src/main/java/org/wise/portal/presentation/web/controllers/survey/SurveyAPIController.java

@@ -21,11 +21,13 @@
 
 import java.io.IOException;
 import java.util.Date;
+import java.util.Locale;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 import javax.servlet.http.HttpSession;
 
+import org.apache.commons.lang3.RandomStringUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.security.authentication.AuthenticationManager;
 import org.springframework.security.authentication.UsernamePasswordAuthenticationToken;
@@ -91,8 +93,9 @@ && isStudentAssociatedWithRun(run, (StudentUserDetails) principal)) {
       SecurityContextHolder.getContext().setAuthentication(null);
     }
     if (underWorkgroupLimit(run)) {
-      User user = this.createNewStudentAccount();
-      loginStudent(request, user);
+      String password = RandomStringUtils.randomAlphanumeric(10);
+      User user = this.createNewStudentAccount(request.getLocale(), password);
+      loginStudent(request, user, password);
       studentService.addStudentToRun(user, projectCode);
       sendRedirect(response, "/student/unit/" + run.getId());
     } else {
@@ -116,26 +119,28 @@ private boolean underWorkgroupLimit(Run run) {
     return workgroupService.getWorkgroupsForRun(run).size() <= 1000;
   }
 
-  private void loginStudent(HttpServletRequest request, User user) {
+  private void loginStudent(HttpServletRequest request, User user, String password) {
     UsernamePasswordAuthenticationToken authReq = new UsernamePasswordAuthenticationToken(
-        user.getUserDetails().getUsername(), "null");
+        user.getUserDetails().getUsername(), password);
     Authentication auth = authenticationManager.authenticate(authReq);
     SecurityContext sc = SecurityContextHolder.getContext();
     sc.setAuthentication(auth);
     HttpSession session = request.getSession(true);
     session.setAttribute(HttpSessionSecurityContextRepository.SPRING_SECURITY_CONTEXT_KEY, sc);
   }
 
-  private User createNewStudentAccount()
+  private User createNewStudentAccount(Locale locale, String password)
       throws AuthorityNotFoundException, DuplicateUsernameException {
     StudentUserDetails sud = new StudentUserDetails();
-    sud.setFirstname("survey_student");
-    sud.setLastname(Integer.toString((int) Math.ceil(Math.random() * 10000)));
+    sud.setFirstname("survey_student_" + RandomStringUtils.randomAlphanumeric(10));
+    sud.setLastname(RandomStringUtils.randomAlphanumeric(10));
     sud.setBirthday(new Date());
-    sud.setPassword("null");
+    sud.setPassword(password);
     sud.setGender(Gender.UNSPECIFIED);
     sud.setEmailAddress("null@null.com");
-    sud.setLanguage("null");
+    sud.setLanguage(locale.getLanguage());
+    sud.setNumberOfLogins(1);
+    sud.setLastLoginTime(new Date());
 
     User user = userService.createUser(sud);
     user.getUserDetails().addAuthority(

src/test/java/org/wise/portal/presentation/web/controllers/survey/SurveyAPIControllerTest.java

@@ -9,6 +9,7 @@
 import java.util.ArrayList;
 import java.util.Date;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.TreeSet;
 
@@ -201,6 +202,7 @@ public void launchSurveyRun_NoIssues_RedirectUnit() throws Exception {
     replay(workgroupService);
     expect(userDetailsService.loadAuthorityByName("ROLE_SURVEY_STUDENT")).andReturn(null);
     replay(userDetailsService);
+    expect(httpServletRequest.getLocale()).andReturn(new Locale("en"));
     expect(httpServletRequest.getSession(true)).andReturn(httpSession);
     replay(httpServletRequest);
     studentService.addStudentToRun(isA(User.class), isA(Projectcode.class));