Skip to content

Commit 1dd2972

Browse files
authored
Merge pull request #2845 from WISE-Community/issue-2844-upgrade-workgroupNodeStatus-to-angular
Upgraded WorkgroupNodeStatus component to Angular
2 parents ff339d3 + 55d3edb commit 1dd2972

6 files changed

Lines changed: 24 additions & 20 deletions

File tree

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import { Component, Input } from "@angular/core";
2+
3+
@Component({
4+
selector: 'workgroup-node-status',
5+
template: `<span class="md-body-2 block center {{statusClass}}">{{statusText}}</span>`
6+
})
7+
export class WorkgroupNodeStatusComponent {
8+
9+
@Input()
10+
statusClass: string = 'text-secondary';
11+
12+
@Input()
13+
statusText: string;
14+
}

src/main/webapp/site/src/app/teacher-hybrid-angular.module.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import { TeacherWebSocketService } from '../../../wise5/services/teacherWebSocke
1414
import { DataService } from './services/data.service';
1515
import { MilestoneService } from '../../../wise5/services/milestoneService';
1616
import { WorkgroupNodeScoreComponent } from '../../../wise5/classroomMonitor/classroomMonitorComponents/shared/workgroupNodeScore/workgroup-node-score.component';
17+
import { WorkgroupNodeStatusComponent } from './classroom-monitor/workgroup-node-status/workgroup-node-status.component';
1718
import { NavItemScoreComponent } from '../../../wise5/classroomMonitor/classroomMonitorComponents/nodeProgress/navItemScore/nav-item-score.component';
1819
import { ManageStudentsComponent } from '../../../wise5/classroomMonitor/manageStudents/manage-students-component';
1920
import { AdvancedProjectAuthoringComponent } from '../../../wise5/authoringTool/advanced/advanced-project-authoring.component';
@@ -59,7 +60,8 @@ import { NavItemProgressComponent } from './classroom-monitor/nav-item-progress/
5960
WorkgroupInfoComponent,
6061
WorkgroupNodeScoreComponent,
6162
NavItemScoreComponent,
62-
WiseAuthoringTinymceEditorComponent
63+
WiseAuthoringTinymceEditorComponent,
64+
WorkgroupNodeStatusComponent
6365
],
6466
imports: [
6567
AngularJSModule

src/main/webapp/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/workgroupItem/workgroupItem.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const WorkgroupItem = {
127127
<workgroup-info [has-alert]="$ctrl.hasAlert" [has-new-alert]="$ctrl.hasNewAlert" [has-new-work]="$ctrl.hasNewWork" [usernames]="$ctrl.workgroupData.displayNames" [workgroup-id]="$ctrl.workgroupId"></workgroup-info>
128128
</div>
129129
<div flex="{{$ctrl.showScore ? 30 : 20}}" layout="row" layout-align="center center">
130-
<workgroup-node-status status-text="{{$ctrl.statusText}}" status-class="{{$ctrl.statusClass}}"></workgroup-node-status>
130+
<workgroup-node-status [status-text]="$ctrl.statusText" [status-class]="$ctrl.statusClass"></workgroup-node-status>
131131
</div>
132132
<div ng-if="$ctrl.showScore" flex="20" layout="row" layout-align="center center">
133133
<workgroup-node-score [score]="$ctrl.score" [max-score]="$ctrl.maxScore"></workgroup-node-score>

src/main/webapp/wise5/classroomMonitor/classroomMonitorComponents/shared/shared.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import Toolbar from './toolbar/toolbar';
1515
import TopBar from './topBar/topBar';
1616
import WorkgroupComponentRevisions from './workgroupComponentRevisions/workgroupComponentRevisions';
1717
import WorkgroupNodeGrading from './workgroupNodeGrading/workgroupNodeGrading';
18-
import WorkgroupNodeStatus from './workgroupNodeStatus/workgroupNodeStatus';
18+
import { WorkgroupNodeStatusComponent } from '../../../../site/src/app/classroom-monitor/workgroup-node-status/workgroup-node-status.component';
1919
import WorkgroupSelect from './workgroupSelect/workgroupSelect';
2020
import * as angular from 'angular';
2121
import { WorkgroupNodeScoreComponent } from './workgroupNodeScore/workgroup-node-score.component';
@@ -41,8 +41,9 @@ const Shared = angular
4141
.component('workgroupComponentRevisions', WorkgroupComponentRevisions)
4242
.component('workgroupNodeGrading', WorkgroupNodeGrading)
4343
.directive('workgroupNodeScore',
44-
downgradeComponent({ component: WorkgroupNodeScoreComponent}) as angular.IDirectiveFactory)
45-
.component('workgroupNodeStatus', WorkgroupNodeStatus)
44+
downgradeComponent({ component: WorkgroupNodeScoreComponent }) as angular.IDirectiveFactory)
45+
.directive('workgroupNodeStatus',
46+
downgradeComponent({ component: WorkgroupNodeStatusComponent }) as angular.IDirectiveFactory)
4647
.component('workgroupSelect', WorkgroupSelect);
4748

4849
export default Shared;

src/main/webapp/wise5/classroomMonitor/classroomMonitorComponents/shared/workgroupNodeStatus/workgroupNodeStatus.ts

Lines changed: 0 additions & 11 deletions
This file was deleted.

src/main/webapp/wise5/classroomMonitor/classroomMonitorComponents/studentGrading/stepItem/stepItem.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ class StepItemController {
4444
}
4545

4646
update() {
47-
let completion = 0;
48-
4947
switch (this.status) {
5048
case -1:
5149
this.statusClass = ' ';
@@ -123,8 +121,8 @@ const StepItem = {
123121
</div>
124122
<div flex="{{ $ctrl.showScore ? 30 : 20 }}" layout="row"
125123
layout-align="center center">
126-
<workgroup-node-status status-text="{{ $ctrl.statusText }}"
127-
status-class="{{ $ctrl.statusClass }}">
124+
<workgroup-node-status [status-text]="$ctrl.statusText"
125+
[status-class]="$ctrl.statusClass">
128126
</workgroup-node-status>
129127
</div>
130128
<div ng-if="$ctrl.showScore" flex="20" layout="row"

0 commit comments

Comments
 (0)