Skip to content

Commit 8191f98

Browse files
Merge pull request #2838 from WISE-Community/issue-2836-vle-unit-plan-ui-bugs
Fixed some VLE Unit Plan UI bugs
2 parents c1b99d9 + 8181907 commit 8191f98

3 files changed

Lines changed: 35 additions & 23 deletions

File tree

src/main/webapp/wise5/themes/default/vle.html

Lines changed: 25 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,30 @@
33
<link rel="stylesheet" href="/wise5/themes/default/style/vle.css" />
44
<style ng-bind-html="::vleController.projectStyle"></style>
55
<disable-delete-keypress>
6-
<listen-for-delete-keypress>
7-
<div class="app-styles" role="main" layout="column" layout-fill
8-
ng-controller="ThemeController as themeCtrl" ng-mousemove="themeCtrl.mouseMoved()"
9-
ng-class="::{'notebook-enabled': vleController.notebookEnabled}">
10-
<ng-include src="::vleController.themePath + '/templates/topbar.html'"></ng-include>
11-
<step-tools show-position="themeCtrl.numberProject"
12-
ng-if="themeCtrl.layoutState === 'node'"></step-tools>
13-
<md-content id="content" flex role="main" ui-scrollpoint-target
14-
ng-class="{'l-nav': themeCtrl.layoutState === 'nav', 'l-node': themeCtrl.layoutState === 'node'}" layout="column">
15-
<div id="nav" ng-include="::vleController.themePath + '/navigation/navigation.html'" ng-show="themeCtrl.layoutState === 'nav'"></div>
16-
<div ng-if="themeCtrl.isEndedAndLocked" style="color: red; display: flex; justify-content: center; align-items: center; height: 30px;">
17-
<span style="border: 1px solid black; border-radius: 3px; padding-left: 8px; padding-right: 8px; background-color: white;">{{ themeCtrl.endedAndLockedMessage }}</span>
18-
</div>
19-
<div id="node" ng-cloak ui-view="nodeView" ng-if="themeCtrl.layoutState === 'node'"></div>
20-
</md-content>
21-
<global-annotations></global-annotations>
22-
<notebook workgroup-id="::vleController.workgroupId"></notebook>
6+
<listen-for-delete-keypress>
7+
<div class="app-styles" role="main" layout="column" layout-fill
8+
ng-controller="ThemeController as themeCtrl" ng-mousemove="themeCtrl.mouseMoved()"
9+
ng-class="::{'notebook-enabled': vleController.notebookEnabled}"
10+
style="position: absolute;">
11+
<ng-include src="::vleController.themePath + '/templates/topbar.html'"></ng-include>
12+
<step-tools show-position="themeCtrl.numberProject" ng-if="themeCtrl.layoutState === 'node'">
13+
</step-tools>
14+
<md-content id="content" flex role="main" ui-scrollpoint-target
15+
ng-class="{'l-nav': themeCtrl.layoutState === 'nav', 'l-node': themeCtrl.layoutState === 'node'}"
16+
layout="column">
17+
<div id="nav" ng-include="::vleController.themePath + '/navigation/navigation.html'"
18+
ng-show="themeCtrl.layoutState === 'nav'"></div>
19+
<div ng-if="themeCtrl.isEndedAndLocked"
20+
style="color: red; display: flex; justify-content: center; align-items: center; height: 30px;">
21+
<span
22+
style="border: 1px solid black; border-radius: 3px; padding-left: 8px; padding-right: 8px; background-color: white;">{{
23+
themeCtrl.endedAndLockedMessage }}</span>
2324
</div>
24-
</listen-for-delete-keypress>
25+
<div id="node" ng-cloak ui-view="nodeView" ng-if="themeCtrl.layoutState === 'node'">
26+
</div>
27+
</md-content>
28+
<global-annotations></global-annotations>
29+
<notebook workgroup-id="::vleController.workgroupId"></notebook>
30+
</div>
31+
</listen-for-delete-keypress>
2532
</disable-delete-keypress>

src/main/webapp/wise5/vle/nav-item/nav-item.component.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<ng-container *ngIf="nodeStatus.isVisible" [ngSwitch]="type">
22
<mat-card *ngSwitchCase="'card'" [ngClass]="{'expanded mat-elevation-z6': expanded}">
3-
<mat-card-header (click)="itemClicked($event)" role="button" matRipple fxLayout="row"
4-
tabindex="0" i18n-aria-label aria-label="Expand or collapse lesson content">
3+
<mat-card-header (click)="itemClicked($event)" (keyup.enter)="itemClicked($event)" role="button"
4+
matRipple fxLayout="row" tabindex="0" i18n-aria-label
5+
aria-label="Expand or collapse lesson content">
56
<node-icon mat-card-avatar class="group-icon" [nodeId]="nodeId" size="36"
67
[icon]="nodeStatus.icon"></node-icon>
78
<mat-card-title class="title" style="color: {{nodeStatus.icon.color}};">
@@ -36,8 +37,7 @@
3637
</mat-card-actions>
3738
</mat-card>
3839
<button mat-list-item class="list-item" *ngSwitchCase="'list'" (click)="itemClicked($event)"
39-
tabindex="0" i18n-title title="Go to {{nodeTitle}}"
40-
[ngClass]="{'group':isGroup}">
40+
tabindex="0" i18n-title title="Go to {{nodeTitle}}" [ngClass]="{'group':isGroup}">
4141
<node-icon matListAvatar [nodeId]="nodeId" [icon]="nodeStatus.icon"></node-icon>
4242
<p matLine>{{ nodeTitle }}</p>
4343
<div fxLayoutAlign="center center" fxLayoutGap="8px">

src/main/webapp/wise5/vle/nav-item/nav-item.component.scss

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,16 @@
1515
}
1616

1717
.mat-card-header {
18+
cursor: pointer;
19+
1820
&:focus, &:hover {
1921
outline: none;
2022

2123
.title {
22-
border-bottom: 1px dashed #aaaaaa;
24+
text-decoration-line: underline;
25+
text-decoration-style: dashed;
26+
text-decoration-color: inherit;
27+
text-decoration-thickness: from-font;
2328
}
2429
}
2530
}

0 commit comments

Comments
 (0)