Cleaned up code related to MC grading. #2935

Author: hirokiterashima

src/main/webapp/wise5/classroomMonitor/classroomMonitorComponents/shared/componentRevisionsInfo/componentRevisionsInfo.ts

@@ -61,12 +61,9 @@ class ComponentRevisionsInfoController {
     }
 
     if (latest) {
-      // calculate the save time of the latest component state
       this.latestComponentStateTime = this.ConfigService.convertToClientTimestamp(
         latest.serverSaveTime
       );
-
-      // check if the latest component state is a submit
       this.latestComponentStateIsSubmit = latest.isSubmit;
     }
   }

src/main/webapp/wise5/components/multipleChoice/multiple-choice-grading/multiple-choice-grading.component.ts

@@ -51,11 +51,9 @@ export class MultipleChoiceGrading extends ComponentGrading {
   }
 
   getChoiceIds(choices: any[]): string[] {
-    const choiceIds: string[] = [];
-    for (const choice of choices) {
-      choiceIds.push(choice.id);
-    }
-    return choiceIds;
+    return choices.map((choice) => {
+      return choice.id;
+    });
   }
 
   processChoices(choices: any[], studentChoices: any[]): any[] {

src/main/webapp/wise5/components/multipleChoice/multipleChoiceService.ts

@@ -208,7 +208,7 @@ export class MultipleChoiceService extends ComponentService {
     return correctChoiceIds;
   }
 
-  getChoicesIdsStudentChose(studentChoices: any[]): any {
+  getChoicesIdsStudentChose(studentChoices: any[]): string[] {
     const studentChoiceIds: string[] = [];
     for (const studentChoice of studentChoices) {
       studentChoiceIds.push(studentChoice.id);
@@ -222,8 +222,8 @@ export class MultipleChoiceService extends ComponentService {
     } else {
       choiceIds1.sort();
       choiceIds2.sort();
-      for (let choiceIdIndex = 0; choiceIdIndex < choiceIds1.length; choiceIdIndex++) {
-        if (choiceIds1[choiceIdIndex] !== choiceIds2[choiceIdIndex]) {
+      for (let i = 0; i < choiceIds1.length; i++) {
+        if (choiceIds1[i] !== choiceIds2[i]) {
           return false;
         }
       }