Cleaned up some Table authoring code. #2902

Author: geoffreykwan

src/main/webapp/wise5/components/table/table-authoring/table-authoring.component.html

@@ -13,20 +13,23 @@
     <mat-label i18n>Columns</mat-label>
     <input matInput
         type="number"
+        min="1"
         [(ngModel)]="authoringComponentContent.numColumns"
         (ngModelChange)="numColumnsChange.next($event)">
   </mat-form-field>
   <mat-form-field class="size-input">
     <mat-label i18n>Rows</mat-label>
     <input matInput
         type="number"
+        min="1"
         [(ngModel)]="authoringComponentContent.numRows"
         (ngModelChange)="numRowsChange.next($event)"/>
   </mat-form-field>
   <mat-form-field class="size-input">
     <mat-label i18n>Global Cell Size</mat-label>
     <input matInput
         type="number"
+        min="1"
         [(ngModel)]="authoringComponentContent.globalCellSize"
         (ngModelChange)="globalCellSizeChange.next($event)"/>
   </mat-form-field>
@@ -152,6 +155,7 @@
           <mat-label i18n>Column Cell Size</mat-label>
           <input matInput
               type="number"
+              min="1"
               [(ngModel)]="columnCellSizes[cellIndex]"
               (ngModelChange)="columnSizeChanged(cellIndex)"/>
         </mat-form-field>

src/main/webapp/wise5/components/table/table-authoring/table-authoring.component.ts

@@ -209,7 +209,7 @@ export class TableAuthoring extends ComponentAuthoring {
     };
   }
 
-  insertRow(y: number): void {
+  insertRow(rowIndex: number): void {
     const tableData = this.authoringComponentContent.tableData;
     const newRow = [];
     const numColumns = this.authoringComponentContent.numColumns;
@@ -221,46 +221,42 @@ export class TableAuthoring extends ComponentAuthoring {
       }
       newRow.push(newCell);
     }
-    tableData.splice(y, 0, newRow);
+    tableData.splice(rowIndex, 0, newRow);
     this.authoringComponentContent.numRows++;
     this.componentChanged();
   }
 
-  deleteRow(y: number): void {
+  deleteRow(rowIndex: number): void {
     if (confirm($localize`Are you sure you want to delete this row?`)) {
       const tableData = this.authoringComponentContent.tableData;
       if (tableData != null) {
-        tableData.splice(y, 1);
+        tableData.splice(rowIndex, 1);
         this.authoringComponentContent.numRows--;
       }
       this.componentChanged();
     }
   }
 
-  insertColumn(x: number): void {
+  insertColumn(columnIndex: number): void {
     const tableData = this.authoringComponentContent.tableData;
     const numRows = this.authoringComponentContent.numRows;
     for (let r = 0; r < numRows; r++) {
-      const tempRow = tableData[r];
-      if (tempRow != null) {
-        const newCell = this.createEmptyCell();
-        tempRow.splice(x, 0, newCell);
-      }
+      const row = tableData[r];
+      const newCell = this.createEmptyCell();
+      row.splice(columnIndex, 0, newCell);
     }
     this.authoringComponentContent.numColumns++;
     this.parseColumnCellSizes(this.authoringComponentContent);
     this.componentChanged();
   }
 
-  deleteColumn(x: number): void {
+  deleteColumn(columnIndex: number): void {
     if (confirm($localize`Are you sure you want to delete this column?`)) {
       const tableData = this.authoringComponentContent.tableData;
       const numRows = this.authoringComponentContent.numRows;
       for (let r = 0; r < numRows; r++) {
-        const tempRow = tableData[r];
-        if (tempRow != null) {
-          tempRow.splice(x, 1);
-        }
+        const row = tableData[r];
+        row.splice(columnIndex, 1);
       }
       this.authoringComponentContent.numColumns--;
       this.parseColumnCellSizes(this.authoringComponentContent);