test(auth): cover hyphenated whitelist owner matching #188
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| package auth | ||
|
|
||
| import ( | ||
| "os" | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| "ghproxy/config" | ||
| ) | ||
|
|
||
| func TestSplitUserRepoWhitelist_PreservesHyphenatedOwner(t *testing.T) { | ||
| user, repo := splitUserRepoWhitelist("jow-/ucode") | ||
|
|
||
| if user != "jow-" { | ||
| t.Fatalf("user = %q, want %q", user, "jow-") | ||
| } | ||
| if repo != "ucode" { | ||
| t.Fatalf("repo = %q, want %q", repo, "ucode") | ||
| } | ||
| } | ||
|
|
||
| func TestInitWhitelist_AllowsHyphenatedOwnerRepo(t *testing.T) { | ||
| tmpDir := t.TempDir() | ||
| whitelistPath := filepath.Join(tmpDir, "whitelist.json") | ||
|
|
||
| content := []byte(`{"whitelist":["jow-/ucode"]}`) | ||
| if err := os.WriteFile(whitelistPath, content, 0o600); err != nil { | ||
| t.Fatalf("write whitelist file: %v", err) | ||
| } | ||
|
|
||
| whitelistInstance = nil | ||
| whitelistInitErr = nil | ||
|
|
||
| cfg := &config.Config{} | ||
| cfg.Whitelist.WhitelistFile = whitelistPath | ||
|
|
||
| if err := InitWhitelist(cfg); err != nil { | ||
| t.Fatalf("InitWhitelist() error = %v", err) | ||
| } | ||
|
|
||
| if !CheckWhitelist("jow-", "ucode") { | ||
| t.Fatal("CheckWhitelist() = false, want true for jow-/ucode") | ||
| } | ||
|
|
||
| if CheckWhitelist("jow", "ucode") { | ||
| t.Fatal("CheckWhitelist() = true, want false for non-hyphenated owner") | ||
| } | ||
|
|
||
| if CheckWhitelist("jow-", "other") { | ||
| t.Fatal("CheckWhitelist() = true, want false for unmatched repo") | ||
| } | ||
|
|
||
| t.Cleanup(func() { | ||
| whitelistInstance = nil | ||
| whitelistInitErr = nil | ||
| }) | ||
|
Comment on lines
+31
to
+56
There was a problem hiding this comment. 将 当前在 Line 53 才注册清理；如果 Line 37-50 之间触发 🛠️ 建议修改- whitelistInstance = nil
- whitelistInitErr = nil
+ prevWhitelistInstance := whitelistInstance
+ prevWhitelistInitErr := whitelistInitErr
+ t.Cleanup(func() {
+ whitelistInstance = prevWhitelistInstance
+ whitelistInitErr = prevWhitelistInitErr
+ })
+ whitelistInstance = nil
+ whitelistInitErr = nil
@@
- t.Cleanup(func() {
- whitelistInstance = nil
- whitelistInitErr = nil
- })Based on learnings: The blacklist and whitelist functionality in auth/ package uses maps for O(1) lookups, separates user-level and repo-level controls, and ensures thread safety using sync.Once. 🤖 Prompt for AI Agents |
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
t.Cleanupfunction should be registered immediately after the global variables are modified. In its current position at the end of the test, it will not be executed ifInitWhitelistfails or if any assertion fails before the registration point. Moving it up ensures that the global state is properly reset even on test failure, preventing side effects on other tests in the same package.