Draft
Fix noon/midnight time display by deriving from numeric time values#123
Conversation
Co-authored-by: jsit <643417+jsit@users.noreply.github.com>
Co-authored-by: jsit <643417+jsit@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix time format on schedule page to use am/pm
Fix noon/midnight time display: 12:00n/12:00m → 12:00pm/12:00am
Nov 18, 2025
jsit
requested changes
Nov 18, 2025
jsit
left a comment
Member
There was a problem hiding this comment.
What the ScheduleService should probably do is derive the time display from the <time> XML element (which represents minutes after midnight) to generate the time string, rather than using <time_str> at all.
Member
|
@copilot Address my feedback please. |
Member
|
@copilot Address my feedback please. |
Copilot stopped work on behalf of
jsit due to an error
November 18, 2025 20:46
Member
|
@copilot Address my feedback please |
Co-authored-by: jsit <643417+jsit@users.noreply.github.com>
Contributor
Author
Copilot
AI
changed the title
Fix noon/midnight time display: 12:00n/12:00m → 12:00pm/12:00am
Fix noon/midnight time display by deriving from numeric time values
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schedule page displays times using "12:00n" for noon and "12:00m" for midnight—a non-standard convention. These should use standard AM/PM format.
Changes
ScheduleService.formatTime(): Updated to derive time display from the<time>XML element (minutes after midnight) instead of using<time_str>. Converts numeric values to 12-hour formatted strings (e.g., 0 → "12:00am", 720 → "12:00pm")SchedulePage: Updated to pass
show.time(numeric) instead ofshow.time_strtoformatTime()Tests: Added comprehensive unit tests for
formatTime()with numeric inputs and integration tests verifying display inSchedulePageMock data: Added noon/midnight show examples for test coverage
Original prompt
<issue_description>Currently on the Schedule Page, noon is represented as "12:00n" and midnight as "12:00m," a convention I've never seen before.
Instead, these should be printed as "12:00pm" and "12:00am".</issue_description>
Comments on the Issue (you are @copilot in this section)
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.