Add review file model and tests

Author: Waishnav

package.json

@@ -28,7 +28,7 @@
     "dev": "node scripts/dev-server.mjs",
     "postinstall": "node scripts/fix-node-pty-permissions.mjs",
     "start": "node dist/cli.js serve",
-    "test": "tsx src/config.test.ts && tsx src/ui/card-types.test.ts && tsx src/ui/patch-display.test.ts && tsx src/apply-patch.test.ts && tsx src/process-platform.test.ts && tsx src/process-sessions.test.ts && tsx src/local-agent-runtime.test.ts && tsx src/local-agent-adapters.test.ts && tsx src/local-agent-availability.test.ts && tsx src/local-agent-profiles.test.ts && tsx src/local-agent-targets.test.ts && tsx src/local-agent-store.test.ts && tsx src/roots.test.ts && tsx src/skills.test.ts && tsx src/workspaces.test.ts && tsx src/review-checkpoints.test.ts && tsx src/oauth-store.test.ts && tsx src/cli.test.ts",
+    "test": "tsx src/config.test.ts && tsx src/ui/card-types.test.ts && tsx src/ui/patch-display.test.ts && tsx src/ui/review-model.test.ts && tsx src/apply-patch.test.ts && tsx src/process-platform.test.ts && tsx src/process-sessions.test.ts && tsx src/local-agent-runtime.test.ts && tsx src/local-agent-adapters.test.ts && tsx src/local-agent-availability.test.ts && tsx src/local-agent-profiles.test.ts && tsx src/local-agent-targets.test.ts && tsx src/local-agent-store.test.ts && tsx src/roots.test.ts && tsx src/skills.test.ts && tsx src/workspaces.test.ts && tsx src/review-checkpoints.test.ts && tsx src/oauth-store.test.ts && tsx src/cli.test.ts",
     "typecheck": "tsc -p tsconfig.json --noEmit"
   },
   "keywords": [],

src/ui/review-model.test.ts

@@ -0,0 +1,79 @@
+import assert from "node:assert/strict";
+import {
+  buildReviewFileEntries,
+  initialReviewPath,
+  reviewFileStatus,
+} from "./review-model.js";
+
+const patch = [
+  "diff --git a/src/old.ts b/src/new.ts",
+  "similarity index 80%",
+  "rename from src/old.ts",
+  "rename to src/new.ts",
+  "index 1111111..2222222 100644",
+  "--- a/src/old.ts",
+  "+++ b/src/new.ts",
+  "@@ -1 +1 @@",
+  "-old value",
+  "+new value",
+  "diff --git a/README.md b/README.md",
+  "index 3333333..4444444 100644",
+  "--- a/README.md",
+  "+++ b/README.md",
+  "@@ -1 +1,2 @@",
+  " title",
+  "+details",
+  "",
+].join("\n");
+
+const entries = buildReviewFileEntries({
+  tool: "show_changes",
+  files: [
+    {
+      path: "src/new.ts",
+      previousPath: "src/old.ts",
+      type: "rename-changed",
+      additions: 1,
+      removals: 1,
+    },
+  ],
+  payload: { patch },
+});
+
+assert.equal(entries.length, 2);
+assert.deepEqual(
+  entries.map(({ path, previousPath, additions, removals, status }) => ({
+    path,
+    previousPath,
+    additions,
+    removals,
+    status,
+  })),
+  [
+    {
+      path: "src/new.ts",
+      previousPath: "src/old.ts",
+      additions: 1,
+      removals: 1,
+      status: "renamed",
+    },
+    {
+      path: "README.md",
+      previousPath: undefined,
+      additions: 1,
+      removals: 0,
+      status: "modified",
+    },
+  ],
+);
+assert.ok(entries.every((entry) => entry.fileDiff));
+
+assert.equal(reviewFileStatus("new"), "added");
+assert.equal(reviewFileStatus("deleted"), "deleted");
+assert.equal(reviewFileStatus("rename-pure"), "renamed");
+assert.equal(reviewFileStatus("change"), "modified");
+
+assert.equal(initialReviewPath(entries), "src/new.ts");
+assert.equal(initialReviewPath(entries, "README.md"), "README.md");
+assert.equal(initialReviewPath(entries, "missing.ts"), "src/new.ts");
+assert.equal(initialReviewPath([]), undefined);

src/ui/review-model.ts

@@ -0,0 +1,93 @@
+import { parsePatchFiles, type FileDiffMetadata } from "@pierre/diffs";
+import type { ToolResultCard } from "./card-types.js";
+
+export type ReviewFileStatus =
+  | "added"
+  | "deleted"
+  | "modified"
+  | "renamed";
+
+export interface ReviewFileEntry {
+  path: string;
+  previousPath?: string;
+  type?: string;
+  additions: number;
+  removals: number;
+  status: ReviewFileStatus;
+  fileDiff?: FileDiffMetadata;
+}
+
+export function buildReviewFileEntries(card: ToolResultCard): ReviewFileEntry[] {
+  const parsedFiles = parseReviewPatch(card.payload?.patch);
+  const parsedByPath = new Map(parsedFiles.map((fileDiff) => [fileDiff.name, fileDiff]));
+  const entries: ReviewFileEntry[] = [];
+
+  for (const file of card.files ?? []) {
+    if (!file.path) continue;
+
+    const fileDiff = parsedByPath.get(file.path);
+    const stats = fileDiff ? reviewFileStats(fileDiff) : undefined;
+    entries.push({
+      path: file.path,
+      previousPath: file.previousPath ?? fileDiff?.prevName,
+      type: file.type,
+      additions: file.additions ?? stats?.additions ?? 0,
+      removals: file.removals ?? stats?.removals ?? 0,
+      status: reviewFileStatus(file.type),
+      fileDiff,
+    });
+    parsedByPath.delete(file.path);
+  }
+
+  for (const fileDiff of parsedFiles) {
+    if (!parsedByPath.has(fileDiff.name)) continue;
+
+    const stats = reviewFileStats(fileDiff);
+    entries.push({
+      path: fileDiff.name,
+      previousPath: fileDiff.prevName,
+      additions: stats.additions,
+      removals: stats.removals,
+      status: fileDiff.prevName && fileDiff.prevName !== fileDiff.name
+        ? "renamed"
+        : "modified",
+      fileDiff,
+    });
+  }
+
+  return entries;
+}
+
+export function parseReviewPatch(patch: string | undefined): FileDiffMetadata[] {
+  if (!patch) return [];
+  return parsePatchFiles(patch, "review", true).flatMap((parsedPatch) => parsedPatch.files);
+}
+
+export function reviewFileStats(
+  fileDiff: FileDiffMetadata,
+): { additions: number; removals: number } {
+  return fileDiff.hunks.reduce(
+    (stats, hunk) => ({
+      additions: stats.additions + hunk.additionLines,
+      removals: stats.removals + hunk.deletionLines,
+    }),
+    { additions: 0, removals: 0 },
+  );
+}
+
+export function reviewFileStatus(type: string | undefined): ReviewFileStatus {
+  if (type === "new") return "added";
+  if (type === "deleted") return "deleted";
+  if (type === "rename-pure" || type === "rename-changed") return "renamed";
+  return "modified";
+}
+
+export function initialReviewPath(
+  entries: ReviewFileEntry[],
+  selectedPath?: string,
+): string | undefined {
+  if (selectedPath && entries.some((entry) => entry.path === selectedPath)) {
+    return selectedPath;
+  }
+  return entries[0]?.path;
+}