3rd attempt to make Bsucc an array

Author: WalterBright

compiler/src/dmd/backend/blockopt.d

@@ -307,6 +307,7 @@ void block_free(ref BlockOpt bo, block* b)
     if (b.Belem)
         el_free(b.Belem);
     list_free(&b.Bsucc,FPNULL);
+    b.Bsucca.dtor();
     b.Bpred.dtor();
     if (OPTIMIZER)
         block_optimizer_free(b);

compiler/src/dmd/backend/cc.d

@@ -205,6 +205,7 @@ nothrow:
     block* Bnext;               // pointer to next block in list
     list_t Bsucc;               // linked list of pointers to successors
                                 //     of this block
+    Barray!(block*) Bsucca;     // and the successor array copy of Bsucc
     Barray!(block*) Bpred;      // and the predecessor array
     int Bindex;                 // into created object stack
     int Bendindex;              // index at end of block

compiler/src/dmd/backend/x86/cgcod.d

@@ -88,7 +88,7 @@ void codgen(Symbol* sfunc)
 /***********************
  * Same as codgen(), but adding in CGstate argument
  * Params:
- *	cg = code generator state
+ *      cg = code generator state
  *      sfunc = function to generate code for
  */
 private @trusted
@@ -98,6 +98,14 @@ void codgenx(ref CGstate cg, Symbol* sfunc)
     assert(sfunc == funcsym_p);
     assert(cseg == funcsym_p.Sseg);
 
+    // Convert Bsucc to Bsucca
+    for (block* b = bo.startblock; b; b = b.Bnext)
+    {
+        foreach (bp; ListRange(b.Bsucc))
+            b.Bsucca.push(list_block(bp));
+        assert(list_nitems(b.Bsucc) == b.Bsucca.length);
+    }
+
     cgreg_init();
     CSE.initialize();
 
@@ -2131,7 +2139,7 @@ bool cssave(elem* e, regm_t regm, bool opsflag)
     /*if (e.Ecount && e.Ecount == e.Ecomsub)*/
     if (e.Ecount && e.Ecomsub)
     {
-	CGstate* cg = &cgstate;
+        CGstate* cg = &cgstate;
         if (!opsflag && cg.pass != BackendPass.final_ && (I32 || I64))
             return false;
 
@@ -2579,7 +2587,7 @@ private void loadcse(ref CodeBuilder cdb,elem* e,reg_t reg,regm_t regm)
         //printf("CSE[%d] = %p, regm = %s\n", i, cse.e, regm_str(cse.regm));
         if (cse.regm & regm)
         {
-	    CGstate* cg = &cgstate;
+            CGstate* cg = &cgstate;
             cg.reflocal = true;
             cse.flags |= CSEload;    /* it was loaded        */
             cg.regcon.cse.value[reg] = e;

compiler/src/dmd/backend/x86/cgreg.d

@@ -607,15 +607,15 @@ void cgreg_spillreg_epilog(block* b,Symbol* s,ref CodeBuilder cdbstore, ref Code
     const bi = b.Bdfoidx;
     //printf("cgreg_spillreg_epilog(block %d, s = '%s')\n",bi,s.Sident.ptr);
     //assert(b.bc == BC.goto_);
-    if (!cgreg_gotoepilog(b.nthSucc(0), s))
+    if (!cgreg_gotoepilog(b.Bsucca[0], s))
         return;
 
     const live = vec_testbit(bi,s.Slvreg) != 0;
 
     // Look at successors to see if we need to load in/out of register
-    foreach (bl; ListRange(b.Bsucc))
+    foreach (bs; b.Bsucca[])
     {
-        const bpi = list_block(bl).Bdfoidx;
+        const bpi = bs.Bdfoidx;
         if (!vec_testbit(bpi,s.Srange))
             continue;
         if (vec_testbit(bpi,s.Slvreg))