[upstream] [BUGFIX] Centralize focus handling in the backend wizard#11
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[upstream] [BUGFIX] Centralize focus handling in the backend wizard#11github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
typo3-backend-wizard never moved focus into a step on its own, leaving it up to individual steps. As a result keyboard users landed on inconsistent elements after navigating between steps, and steps that load their content asynchronously received no focus at all. Handle focus in the wizard itself. On every step change focus is directed at the selected radio, otherwise the first form control and otherwise the primary action button. Steps that build their content asynchronously re-render the wizard once their data settles, so the attempt is repeated on each update until a target appears; steps no longer need to wire up focus themselves. Enter pressed inside a bare input now advances the wizard, emulating a form submit. The ad-hoc focus workaround in the form wizard's settings step is removed as it is now handled centrally. Resolves: #110151 Releases: main, 14.3 Change-Id: I146edb88c15da039b7d2d6243f27d0d72f2fef4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/94804 Tested-by: core-ci <typo3@b13.com> Tested-by: Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com> (cherry picked from commit 027a95102318c700b907838cfafa3b19738ec144) [CONFLICT — manual resolution required]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatisch vorgeschlagener Cherry-pick aus TYPO3-CMS/form @ 14.3.
Upstream-Commit
027a95102318c700b907838cfafa3b19738ec144Commit-Message
Upstream-Commit-Message anzeigen
Erzeugt von
.github/workflows/upstream-sync.yml.Um diesen Commit künftig nicht erneut vorzuschlagen, schließe die PR ohne Merge — der Marker unten bleibt erhalten.