-
Notifications
You must be signed in to change notification settings - Fork 16
feat: add stream subcommand for live terminal session broadcasting
#278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4e1acf1
Initial plan
Copilot f822941
feat: add stream subcommand for live terminal session streaming
Copilot 30593d2
address stream command review feedback
Codex 8fbc6f6
Merge branch 'main' into copilot/support-live-streaming
ibigbug 06a4fbd
fix: fix CI compilation errors in stream.rs
Copilot 5c60661
fix: add wildcard arm to non-exhaustive MaybeTlsStream match
Copilot 8de0984
fix: address PR review comments and fix CI test compilation
Claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,21 @@ | ||
| mod asciinema; | ||
|
|
||
| pub struct StreamInfo { | ||
| pub id: String, | ||
| pub url: String, | ||
| pub ws_producer_url: String, | ||
| } | ||
|
|
||
| pub trait ApiService { | ||
| fn auth(&self); | ||
| fn upload(&self, filepath: &str) -> Option<String>; | ||
| /// Create a new live stream on the server. Returns `StreamInfo` with the public viewer | ||
| /// URL and the WebSocket producer URL to push events to. | ||
| fn create_stream(&self, cols: u16, rows: u16) -> Option<StreamInfo>; | ||
| /// Build the WebSocket producer URL for an *existing* stream identified by `stream_id`. | ||
| fn get_stream_ws_url(&self, stream_id: &str) -> String; | ||
| /// Return the `Authorization` header value to authenticate WebSocket connections. | ||
| fn get_auth_header(&self) -> String; | ||
| } | ||
|
|
||
| pub use asciinema::Asciinema; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New API helpers
create_stream,get_stream_ws_url, andget_auth_headerwere added, but the test module only covers config creation. Adding unit tests forget_stream_ws_url(http/https, trailing slash handling) andget_auth_header(expected Basic base64 format) would help prevent regressions without needing network calls.