Refactor API Key Handling and Fix Python Version Check#18
Open
abhijitgawai wants to merge 3 commits into
Open
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces improvements to security configuration and fixes a Python version compatibility issue.
Refactored Client and WebsocketClient to check for API_KEY and SECRET_KEY environment variables by default.
This allows users to store credentials securely (e.g., in a .env file or system environment) properly, rather than hardcoding them in scripts.
Updated README.md to document this configuration method.
Updated test scripts (rest/test.py, websocket/test.py) to utilize these environment variables.
2. Python Version Compatibility Fix
Fixed an init.py error where Python versions newer than 3.7 (e.g., 3.10, 3.12) were incorrectly triggering a "Python>=3.7 required" exception due to flawed logic.
Replaced the manual version check with sys.version_info for robust comparison.