feat(dropdown): add keyboard navigation (#842)#1011
Closed
wanchun wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closed as part of v3 rebuild from chore/test-infra. Original v1/v2 PRs being superseded by clean re-implementation (vitest + playwright + docs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842
Adds keyboard navigation to FDropdown menu items.
Implementation:
dropdown.tsx: AddedactiveIndexstate,getNextValidIndexhelper,handleKeydownhandler. ArrowDown/ArrowUp move focus between items (with wraparound), Enter activates the active item, Escape closes the dropdownstyle/index.less: Added.is-activestyle matching hover backgroundFiles changed: 3. No lockfile. No test-infra changes.