Try changing call effects

Author: stevenfontanella

src/ir/effects.h

@@ -725,35 +725,23 @@ class EffectAnalyzer {
         return;
       }
 
-      // Get the target's effects, if they exist. Note that we must handle the
-      // case of the function not yet existing (we may be executed in the middle
-      // of a pass, which may have built up calls but not the targets of those
-      // calls; in such a case, we do not find the targets and therefore assume
-      // we know nothing about the effects, which is safe).
-      const EffectAnalyzer* targetEffects = nullptr;
-      if (auto* target = parent.module.getFunctionOrNull(curr->target)) {
-        targetEffects = target->effects.get();
-      }
-      if (targetEffects) {
-        populateEffectsFromGlobalEffects(*targetEffects, curr);
+      if (auto* target = parent.module.getFunctionOrNull(curr->target);
+          target->effects) {
+        populateEffectsFromGlobalEffects(*target->effects, curr);
         return;
       }
+      parent.calls = true;
 
-      if (curr->isReturn) {
-        parent.branchesOut = true;
-        // When EH is enabled, any call can throw.
-        if (parent.features.hasExceptionHandling()) {
+      // If EH is enabled and we don't have global effects information,
+      // assume that the call body may throw.
+      if (parent.features.hasExceptionHandling()) {
+        if (curr->isReturn) {
           parent.hasReturnCallThrow = true;
         }
-      }
 
-      parent.calls = true;
-      // When EH is enabled, any call can throw. Skip this for return calls
-      // because the throw is already more precisely captured by the combination
-      // of `hasReturnCallThrow` and `branchesOut`.
-      if (parent.features.hasExceptionHandling() && parent.tryDepth == 0 &&
-          !curr->isReturn) {
-        parent.throws_ = true;
+        if (parent.tryDepth == 0 && !curr->isReturn) {
+          parent.throws_ = true;
+        }
       }
     }
     void visitCallIndirect(CallIndirect* curr) {