Skip to content

Commit e29edae

Browse files
Exclude wide-arithmetic.wast from fuzzer (#8663)
Fix for #8638 (comment).
1 parent cae3fbb commit e29edae

4 files changed

Lines changed: 9 additions & 2 deletions

File tree

Contributing.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,7 @@ Use this handy checklist to make sure your new instructions are fully supported:
3030
- [ ] JS API tested in test/binaryen.js/kitchen-sink.js
3131
- [ ] Tests added in test/spec
3232
- [ ] Tests added in test/lit
33+
- [ ] Tests are used as seeds for the fuzzer. If V8 doesn't support the
34+
test, or if the new instruction isn't guarded by a wasm-validator check,
35+
then either add the corresponding feature to DISALLOWED_FEATURES_IN_V8 or
36+
mark the test as unfuzzable.

scripts/bundle_clusterfuzz.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@
111111
'--disable-stack-switching',
112112
'--disable-relaxed-atomics',
113113
'--disable-multibyte',
114+
'--disable-wide-arithmetic',
114115
]
115116

116117
with tarfile.open(output_file, "w:gz") as tar:

scripts/clusterfuzz/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@
9595
'--disable-strings',
9696
'--disable-stack-switching',
9797
'--disable-relaxed-atomics',
98+
'--disable-wide-arithmetic',
9899
]
99100

100101

scripts/fuzz_opt.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@
7777
'stack-switching',
7878
'relaxed-atomics',
7979
'multibyte',
80+
'wide-arithmetic',
8081
]
8182

8283

@@ -916,7 +917,7 @@ def can_run(self, wasm):
916917
if random.random() < 0.5:
917918
return False
918919
# wasm2c doesn't support most features
919-
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'custom-descriptors', 'relaxed-atomics'])
920+
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'custom-descriptors', 'relaxed-atomics', 'wide-arithmetic'])
920921

921922
@override
922923
def run(self, wasm):
@@ -1237,7 +1238,7 @@ def can_run_on_wasm(self, wasm):
12371238
# implement wasm suspending using JS async/await.
12381239
if JSPI:
12391240
return False
1240-
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'multimemory', 'memory64', 'custom-descriptors', 'relaxed-atomics'])
1241+
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'multimemory', 'memory64', 'custom-descriptors', 'relaxed-atomics', 'wide-arithmetic'])
12411242

12421243

12431244
# Returns the wat for a wasm file. If it is already wat, it just returns that

0 commit comments

Comments
 (0)