Fuzzer: Merge and optimize even with closed world in Two()#7963
Merged
Conversation
tlively
approved these changes
Oct 9, 2025
| # Run at relatively high priority, as this is the main place we check cross- | ||
| # module interactions. | ||
| frequency = 1 | ||
| frequency = 1 # TODO: We may want even higher priority here |
Member
Author
There was a problem hiding this comment.
https://www.youtube.com/watch?v=4xgx4k83zzc
Seriously though, yes, "1" here means we use it with chance 100% when we pick it. But it still is limited by that chance to be picked out of the list in the first place. If e.g. we put it in the list twice, it would have double the chance it currently has.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key idea here is that we can take two separate modules, merge them, and then
optimize in the most aggressive manner (even closed world) internally, as any
optimization change after the merge is a bug. (We must still avoid optimizing
the separate modules in closed world, which happens later in this fuzzer.)
Compare the full merged output to the pre-merged, for maximal coverage. This
requires fixing up export names after the merge, which is a little annoying, but
seems worth it.
This mode has been (re)finding WebAssembly/custom-descriptors#57 , so it should not land until we fix it here.