Skip to content

feat: Update jsoo build process for libbinaryen #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
Apr 1, 2026
+2 −2
Merged

feat: Update jsoo build process for libbinaryen #8565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,8 @@ if(EMSCRIPTEN)
if(JS_OF_OCAML)
# js_of_ocaml needs a specified variable with special comment to provide the library to consumer
target_link_libraries(binaryen_js PRIVATE "--extern-pre-js=${CMAKE_CURRENT_SOURCE_DIR}/src/js/binaryen.jsoo-extern-pre.js")
# Currently, js_of_ocaml can only process ES5 code
target_link_libraries(binaryen_js PRIVATE optimized "--closure-args=\"--language_out=ECMASCRIPT5\"")
# js_of_ocaml does not support top level await
target_link_libraries(binaryen_js PRIVATE "-sWASM_ASYNC_COMPILATION=0")
else()
target_link_libraries(binaryen_js PRIVATE "-sEXPORT_ES6")
endif()
Expand Down
Loading