Add subtask.cancel/task.cancel built-ins#506
Merged
Merged
Conversation
dicej
approved these changes
Apr 28, 2025
dicej
reviewed
Apr 28, 2025
alexcrichton
approved these changes
Apr 28, 2025
| (canon subtask.cancel (core func $f)) | ||
| ``` | ||
| validation specifies: | ||
| * `$f` is given type `(func (param i32))` |
There was a problem hiding this comment.
May I ask if this should've been (func (param i32) (result i32))?
Member
Author
There was a problem hiding this comment.
Yes, you're right; good catch, and thanks! Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the subtask.cancel/task.cancel built-ins as sketched in #495 to support subtask cancellation. For a high-level summary, see the new "Cancellation" section added to Async.md in this PR.