CABI: Remove the zero-index special case for callback return value#517
Merged
Conversation
dicej
approved these changes
May 16, 2025
alexcrichton
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a small optimization in the callback event loop which allowed the returned waitable-set index to be
0(in which case the previous waitable-set was used). As is, there is no consideration for what happens if youwaitable-set.dropthe waitable-set in the interim, and adding rules to fix it seems to add more trouble than this small optimization is worth. Since0will always trap, we can always re-add this in the future if there were perf data suggesting it.