chore: various async fixes#527
Merged
lukewagner merged 7 commits intoJun 5, 2025
Merged
Conversation
This comit adds some fixes/rewordings for the async sections. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
lukewagner
approved these changes
Jun 4, 2025
Comment on lines
+283
to
+284
| Based on this, the call stack for a component to host-defined import will be of | ||
| the general form: |
Member
There was a problem hiding this comment.
I'm not sure this sentence is an improvement.
Collaborator
Author
There was a problem hiding this comment.
yeah, I can revert this -- I wasn't sure the "at any time" was necessary but it's hard to restate this, and I think the phrase "cal stack" was used too many times.
Maybe will be a callstack of the general form makes sense.
Collaborator
Author
There was a problem hiding this comment.
OK I've updated it, WDYT?
Member
Good start, and I like the vertical format with annotations on the arrows. Riffing on it a bit, wdyt: |
Co-authored-by: Luke Wagner <mail@lukewagner.name>
vados-cosmonic
commented
Jun 5, 2025
lukewagner
approved these changes
Jun 5, 2025
Member
lukewagner
left a comment
There was a problem hiding this comment.
Beautiful, thanks. One suggestion:
Co-authored-by: Luke Wagner <mail@lukewagner.name>
Collaborator
Author
|
Thanks again for the close review @lukewagner ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stuff that I ran into as I was going through:
fetch->from-streamI think the call stack example needs to be made more approachable, but I don't know how to make it clearer -- I just wasn't able to wrap my mind around which parts were the component versus the host.
The concept that component-incoming async calls are
Tasks and component-outgoing async calls areSubTasks which pair with aTaskon the other side make sense. The additional wrinkle that when hosts call into components there is only aTaskmakes sense, but I couldn't make sense out of the following...I didn't put it in the PR but would like opinions on the following: