Skip to content

fix: output types of Task.yield_ #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukewagner merged 1 commit into from
Jun 9, 2025
Merged

fix: output types of Task.yield_ #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion design/mvp/CanonicalABI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ external I/O. This is emulated in the Python code below by waiting on an
immediately-resolved future, which calls the `OnBlock` callback, which allows
control flow to switch to other `asyncio.Task`s.
```python
async def yield_(self, sync) -> bool:
async def yield_(self, sync) -> EventTuple:
if self.state == Task.State.PENDING_CANCEL:
self.state = Task.State.CANCEL_DELIVERED
return (EventCode.TASK_CANCELLED, 0, 0)
Expand Down
2 changes: 1 addition & 1 deletion design/mvp/canonical-abi/definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ async def wait_for_event(self, waitable_set, sync) -> EventTuple:
waitable_set.num_waiting -= 1
return e

async def yield_(self, sync) -> bool:
async def yield_(self, sync) -> EventTuple:
if self.state == Task.State.PENDING_CANCEL:
self.state = Task.State.CANCEL_DELIVERED
return (EventCode.TASK_CANCELLED, 0, 0)
Expand Down