Add test/values/trap-in-post-return.wast#535
Merged
Merged
Conversation
dicej
approved these changes
Jun 25, 2025
Collaborator
dicej
left a comment
There was a problem hiding this comment.
That's a big file! Thanks for adding it.
Alex and I are deep in the process of upstreaming wasip3-prototyping into the main wasmtime repo, so I might not have a chance to get this test passing this week, but it's on my to-do list.
Collaborator
|
FYI, I've got the test passing in this branch, but I'm going to hold off PRing that until we're done upstreaming async support to Wasmtime. We'll probably add a config option to get the old behavior (i.e. allowing import calls in post-return functions) in case this breaks real-world pre-async code. |
6bf50c7 to
47a0f47
Compare
Member
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a .wast calling all the
canonfunction that contain amay_leavetrap from under apost-returnfunction testing that they trap.