chore: rename revoke_buffer to reclaim_buffer#538
Merged
lukewagner merged 1 commit intoJun 26, 2025
Conversation
Member
|
Thanks! Could you also update the |
vados-cosmonic
force-pushed
the
chore=rename-revoke-buffer
branch
from
4485629 to
097e8df
Compare
This commit renames `revoke_buffer` which is used during stream copying to `reclaim_buffer` which hopefully better conveys (if only slightly) the handoff/change in ownership of the buffer in use. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
chore=rename-revoke-buffer
branch
from
097e8df to
fde7802
Compare
Collaborator
Author
|
Ah thanks @lukewagner -- done! |
Member
|
Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames
revoke_bufferwhich is used during stream copying toreclaim_bufferwhich hopefully better conveys (if only slightly) the handoff/change in ownership of the buffer in use.