Fix <interfacename> grammar to match <pkgpath>#630
Merged
lukewagner merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
alexcrichton
approved these changes
Apr 1, 2026
LFsWang
added a commit
to LFsWang/WasmEdge
that referenced
this pull request
Apr 2, 2026
The spec updated interfacename grammar from <label> to <words>, confirming that package names must be lowercase-only kebab-case. Refs: WebAssembly/component-model#630 Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: LFsWang <tnst92002@gmail.com>
LFsWang
added a commit
to LFsWang/WasmEdge
that referenced
this pull request
Apr 2, 2026
The spec updated interfacename grammar from <label> to <words>, confirming that package names must be lowercase-only kebab-case. Refs: WebAssembly/component-model#630 Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: LFsWang <tnst92002@gmail.com>
hydai
pushed a commit
to WasmEdge/WasmEdge
that referenced
this pull request
Apr 3, 2026
The spec updated interfacename grammar from <label> to <words>, confirming that package names must be lowercase-only kebab-case. Refs: WebAssembly/component-model#630 Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: LFsWang <tnst92002@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #628, this fixes a discrepancy between
interfacenameandpkgname. There's already atest/names/kebab.wastthat matches this change and the wasm-tools implementation.