Update bits used for malformed memory/table/global flags#1936
Merged
Conversation
This commit updates a few locations where tests assert that various bits are invalid to set for memories, tables, and globals: * For memories bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly threads proposal to indicate a shared memory. Additionally bit 0b100 is used by the memory64 proposal and the 0b1000 bit is used by the custom-page-sizes proposal. This changes the test to assert that bit 0b10000 is invalid as it's not in use by any proposal. * For tables bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly shared-everything-threads proposal to indicate a shared table. Additionally bit 0b100 is used by the memory64 proposal. This changes the test to assert that bit 0b1000 is invalid as it's not in use by any proposal. * For globals bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly shared-everything-threads proposal to indicate a shared global. This changes the test to assert that bit 0b100 is invalid as it's not in use by any proposal.
rossberg
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates a few locations where tests assert that various bits are invalid to set for memories, tables, and globals:
For memories bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly threads proposal to indicate a shared memory. Additionally bit 0b100 is used by the memory64 proposal and the 0b1000 bit is used by the custom-page-sizes proposal. This changes the test to assert that bit 0b10000 is invalid as it's not in use by any proposal.
For tables bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly shared-everything-threads proposal to indicate a shared table. Additionally bit 0b100 is used by the memory64 proposal. This changes the test to assert that bit 0b1000 is invalid as it's not in use by any proposal.
For globals bit 0b10 of the "flags" byte was tested to ensure that it's invalid, but this bit is used in the WebAssembly shared-everything-threads proposal to indicate a shared global. This changes the test to assert that bit 0b100 is invalid as it's not in use by any proposal.