Skip to content

[interpreter] Catch failing string conversion in JS harness#2011

Merged
rossberg merged 3 commits into
mainfrom
js.error-string
Oct 14, 2025
Merged

[interpreter] Catch failing string conversion in JS harness#2011
rossberg merged 3 commits into
mainfrom
js.error-string

Conversation

@rossberg
Copy link
Copy Markdown
Member

Fix #2010 wrt to interpreter's own test harness.

@Ms2ger, can you or somebody else adjust the other test harnesses?

@rossberg rossberg requested a review from Ms2ger October 12, 2025 18:36
Copy link
Copy Markdown
Collaborator

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I copied your changes to the other harnesses, but didn't test them.

@rossberg
Copy link
Copy Markdown
Member Author

Thanks!

@rossberg rossberg merged commit a499738 into main Oct 14, 2025
1 check passed
@rossberg rossberg deleted the js.error-string branch October 14, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] assert_return should not assume it can stringify ref.array values

2 participants