Create specification/wasm-latest#2064
Conversation
tlively
changed the title
tlively
force-pushed
the
wasm-latest-spectec
branch
from
876018f to
2e3e94f
Compare
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Great, thanks!
Two comments:
-
It would be great if the diff check is also invoked locally, e.g., as part of the
checktarget in the specification dir's Makefile. The shell script could live there as well. -
I just noticed that 6.3-text.modules should be named 6.4-text.modules. This seems like a good time to fix that. :)
| uses: actions/checkout@v4 | ||
| - name: Diff wasm-latest | ||
| run: bash .github/workflows/diff-wasm-latest.sh | ||
| build-core-spec: |
|
Oops, sorry, only saw the follow-up now. :) |
But we wouldn't want to run this on forks, right? Since a local development could have both WebAssembly/spec and proposal repos as upstreams, I don't think there's a good way to automatically detect whether this check should run or not locally. |
tlively
force-pushed
the
wasm-latest-spectec
branch
from
2e3e94f to
5a9f3db
Compare
|
Well the CI script works :) Now I have to figure out how to pull the latest changes to wasm-3.0 into this cursed merge commit structure... |
To give proposal repos a consistent location to make changes to the SpecTec source and to simplify merging those proposals back into the spec repo once they are completed. The new directory is a copy of the wasm-3.0 directory in its current state, created via a sequence of git mv and merge operations to preserve the blame history in both directories. Also add a new CI script ensuring that the contents of wasm-latest match the contents of the highest versioned wasm-X.Y directory. This will ensure that bug fixes are applied in both directories. As a drive-by fix, rename 6.3-text.modules.spectec to 6.4-text.modules.spectec.
tlively
force-pushed
the
wasm-latest-spectec
branch
from
5a9f3db to
0e2749e
Compare
|
Looks like the fancy moves and merges to preserve history didn't survive the PR process :( We could force push this branch to main, but it might not be worth it. Wdyt? |
|
No real surprise, I suppose... Yeah, please push it manually. Especially since there are other PRs in flight that touch the spec, so we already need the history now, I think. |
This reverts commit 76c81e0. The merge commit necessary to preseve git history in both the wasm-3.0 and wasm-latest directories did not survive the PR process. We will try again, pushing the commits directly to main.
2 participants
To give proposal repos a consistent location to make changes to the
SpecTec source and to simplify merging those proposals back into the
spec repo once they are completed. The new directory is a copy of the
wasm-3.0 directory in its current state, created via a sequence of git
mv and merge operations to preserve the blame history in both
directories.
Also add a new CI script ensuring that the contents of wasm-latest match
the contents of the highest versioned wasm-X.Y directory. This will
ensure that bug fixes are applied in both directories.