Skip to content

Fix cross-references to constant expressions #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossberg merged 1 commit into from
Apr 20, 2026
+9 −9
Merged

Fix cross-references to constant expressions #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions document/core/appendix/changes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ Extended Constant Expressions

Allowed basic numeric computations in constant expressions. [#proposal-extconst]_

* Extended set of :ref:`constant instructions <valid-const>` with:
* Extended set of :ref:`constant instructions <valid-constant>` with:

- :math:`\K{i}\X{nn}\K{.add}`
- :math:`\K{i}\X{nn}\K{.sub}`
Expand Down Expand Up @@ -584,7 +584,7 @@ Added managed reference types. [#proposal-gc]_
- |ANYCONVERTEXTERN|
- |EXTERNCONVERTANY|

* Extended set of :ref:`constant instructions <valid-const>` with:
* Extended set of :ref:`constant instructions <valid-constant>` with:

- |REFI31|
- |STRUCTNEW|
Expand Down
12 changes: 6 additions & 6 deletions document/core/util/macros.def
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,15 +1259,15 @@
.. |vdashinstrs| mathdef:: \xref{valid/instructions}{valid-instrs}{\vdash}
.. |vdashcatch| mathdef:: \xref{valid/instructions}{valid-catch}{\vdash}
.. |vdashexpr| mathdef:: \xref{valid/instructions}{valid-expr}{\vdash}
.. |vdashinstrconst| mathdef:: \xref{valid/instructions}{valid-const}{\vdash}
.. |vdashexprconst| mathdef:: \xref{valid/instructions}{valid-const}{\vdash}
.. |vdashexprokconst| mathdef:: \xref{valid/instructions}{valid-const}{\vdash}
.. |vdashinstrconst| mathdef:: \xref{valid/instructions}{valid-constant}{\vdash}
.. |vdashexprconst| mathdef:: \xref{valid/instructions}{valid-constant}{\vdash}
.. |vdashexprokconst| mathdef:: \xref{valid/instructions}{valid-constant}{\vdash}

.. |OKcatch| mathdef:: \xref{valid/instructions}{valid-catch}{\K{ok}}

.. |CONSTinstrconst| mathdef:: \xref{valid/instructions}{valid-const}{\K{const}}
.. |CONSTexprconst| mathdef:: \xref{valid/instructions}{valid-const}{\K{const}}
.. |CONSTexprokconst| mathdef:: \xref{valid/instructions}{valid-const}{\K{const}}
.. |CONSTinstrconst| mathdef:: \xref{valid/instructions}{valid-constant}{\K{const}}
.. |CONSTexprconst| mathdef:: \xref{valid/instructions}{valid-constant}{\K{const}}
.. |CONSTexprokconst| mathdef:: \xref{valid/instructions}{valid-constant}{\K{const}}

.. |vdashexternidx| mathdef:: \xref{valid/modules}{valid-externidx}{\vdash}

Expand Down
2 changes: 1 addition & 1 deletion document/core/valid/modules.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,4 +289,4 @@ $${rule: Module_ok}
However, this recursion is just a specification device.
All types needed to construct ${:C} can easily be determined from a simple pre-pass over the module that does not perform any actual validation.

Globals, however, are not recursive but evaluated sequentially, such that each :ref:`constant expressions <valid-const>` only has access to imported or previously defined globals.
Globals, however, are not recursive but evaluated sequentially, such that each :ref:`constant expressions <valid-constant>` only has access to imported or previously defined globals.
Loading