Refactor test runner#221
Merged
Merged
Conversation
When adding HTTP support to the runner, I got a bit distracted about code duplication, and how we had so much state in the run_test method, then realized that all the op interpretation isn't the responsibility of the runtime adapter, rather of the test case... and ended up with this big honkin' patch.
wingo
force-pushed
the
test-suite-runner-refactor
branch
from
0e93a55 to
625f567
Compare
Collaborator
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
LGTM, thanks for the refactor. Only one question below.
Removes some duplication and complexity. Also, tighten up validation to ensure we use streams (readable or writable pipes, sockets) in an appropriate way.
saulecabrera
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding HTTP support to the runner, I got a bit distracted about code duplication, and how we had so much state in the run_test method, then realized that all the op interpretation isn't the responsibility of the runtime adapter, rather of the test case... and ended up with this big honkin' patch.