Properly set properties in bluetooth.simulateCharacteristic#660
Merged
Conversation
reillyeon
approved these changes
Jul 21, 2025
Contributor
reillyeon
left a comment
reillyeon
left a comment
There was a problem hiding this comment.
LGTM with grammar nits
| 1. If |params|[`"type"`] is `"add"`: | ||
| 1. If |characteristicMapping|[|characteristicUuid|] [=map/exists=], return [=error=] with | ||
| [=error code=] [=invalid element state=]. | ||
| 1. If |params|[`"characteristicProperties"`] does not [=map/exists=], return [=error=] with [=error code=] [=invalid argument=]. |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. If |params|[`"characteristicProperties"`] does not [=map/exists=], return [=error=] with [=error code=] [=invalid argument=]. | |
| 1. If |params|[`"characteristicProperties"`] does not [=map/exist=], return [=error=] with [=error code=] [=invalid argument=]. |
github-actions Bot
added a commit
that referenced
this pull request
Jul 21, 2025
SHA: 5508fa5 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 21, 2025
SHA: 5508fa5 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 21, 2025
SHA: 5508fa5 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot
added a commit
that referenced
this pull request
Jul 21, 2025
SHA: 5508fa5 Reason: push, by chengweih001 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in the automation command
bluetooth.simulateCharacteristicthat it doesn't set the simulated characteristic properties properly.Preview | Diff