Skip to content

Feature/con 507 code review updates redo#822

Open
tw2113 wants to merge 5 commits intorelease2180from
feature/CON-507-code-review-updates-redo
Open

Feature/con 507 code review updates redo#822
tw2113 wants to merge 5 commits intorelease2180from
feature/CON-507-code-review-updates-redo

Conversation

@tw2113
Copy link
Copy Markdown
Member

@tw2113 tw2113 commented Mar 25, 2026

This PR handles the following:

  1. Continued function/method type declaration and return type declaration.
  2. PHP modernization for our supported versions, to simplify code.
  3. New API Utility class to create smaller classes and reduce class sizes.
  4. Updated API method usage to use Utility class instead of original location.
  5. Move deprecated functions to appropriate file.

class-api.php file

The changes for this file are 2 fold.

  1. Extraction of utility methods to the new utility class
  2. Reorganization of methods to better group together.
    a. Authorization, authentication, api, access/refresh token management functions
    b. get/add/update methods for contacts, lists, etc.

Troubleshooting API stuff was at times hard to follow with associated methods being at opposite ends of the class.

@tw2113 tw2113 requested a review from lindseywb March 25, 2026 16:32
Copy link
Copy Markdown

@lindseywb lindseywb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants