Conversation
…thods Register tables from class-string in a single call. Supports both attribute-based classes (#[Table]/#[Column]) and Table subclasses (MySQLTable/MSSQLTable). Automatically converts tables to the connection engine via TableFactory::map(). Also fixes a bug in TableFactory where the missing Column import caused cross-engine table conversion to fail with a TypeError. Closes #138
usernane
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
============================================
+ Coverage 74.72% 75.06% +0.34%
- Complexity 2167 2174 +7
============================================
Files 54 54
Lines 5384 5403 +19
============================================
+ Hits 4023 4056 +33
+ Misses 1361 1347 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add convenience methods to register tables from a class-string, supporting both attribute-based classes and Table subclasses with automatic engine conversion.
Motivation
Registering attribute-based tables required 3 verbose steps (instantiate builder, get table, add table). This reduces it to a single call. Fixes #138.
Changes
Database::addTableFromClass(string $className): TableDatabase::addTablesFromClasses(array $classNames): arrayColumnimport inTableFactorythat broke cross-enginemap()conversionHow to Test / Verify
Unit tests via PHPUnit:
All 17 tests pass. Full Common and MySQL suites also pass with no regressions.
Breaking Changes and Migration Steps
None
Checklist
Related issues
Closes #138