Skip to content

Commit 369d756

Browse files
author
Ibrahim BinAlshikh
committed
fix(test): fix flaky StartSessionMiddleware test on PHP 8.1
Assert isRunning() instead of exact SessionStatus::NEW to avoid test ordering dependency in CI.
1 parent ce6dcff commit 369d756

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

tests/WebFiori/Framework/Tests/Middleware/StartSessionMiddlewareTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
use PHPUnit\Framework\TestCase;
55
use WebFiori\Framework\Middleware\StartSessionMiddleware;
66
use WebFiori\Framework\Session\SessionsManager;
7-
use WebFiori\Framework\Session\SessionStatus;
87
use WebFiori\Http\Request;
98
use WebFiori\Http\Response;
109

@@ -54,7 +53,7 @@ public function testBeforeStartsSession() {
5453
$active = SessionsManager::getActiveSession();
5554
$this->assertNotNull($active);
5655
$this->assertEquals('wf-session', $active->getName());
57-
$this->assertEquals(SessionStatus::NEW, $active->getStatus());
56+
$this->assertTrue($active->isRunning());
5857
}
5958

6059
/** @test */

0 commit comments

Comments
 (0)