fix: remove silent try-catch in StartSessionMiddleware::after()

The empty catch(Error) block silently swallowed all errors, hiding
the static call bug fixed in #297. Errors in middleware should
propagate rather than be silently ignored.

Fixes #298

Author: Ibrahim BinAlshikh

WebFiori/Framework/Middleware/StartSessionMiddleware.php

@@ -2,7 +2,6 @@
 
 namespace WebFiori\Framework\Middleware;
 
-use Error;
 use WebFiori\Framework\Session\SessionsManager;
 use WebFiori\Http\Request;
 use WebFiori\Http\Response;
@@ -21,15 +20,12 @@ public function __construct() {
         $this->setPriority(PHP_INT_MAX);
         $this->addToGroup('web');
     }
-    public function after(Request $request, Response $response) {
-        try {
-            $sessionsCookiesHeaders = SessionsManager::getCookiesHeaders();
-
-            foreach ($sessionsCookiesHeaders as $headerVal) {
-                $response->addHeader('set-cookie', $headerVal);
-            }
-        } catch (Error $exc) {
-        }
+    public function after(Request $request, Response $response) {
+        $sessionsCookiesHeaders = SessionsManager::getCookiesHeaders();
+
+        foreach ($sessionsCookiesHeaders as $headerVal) {
+            $response->addHeader('set-cookie', $headerVal);
+        }
     }
 
     public function afterSend(Request $request, Response $response) {