Merge pull request #304 from WebFiori/dev

usernane · web-flow · commit ab081fb22a56 · 2026-04-30T00:14:31.000+03:00
fix: off-by-one in middleware after() and afterSend() loops
diff --git a/WebFiori/Framework/App.php b/WebFiori/Framework/App.php
@@ -164,7 +164,7 @@ private function __construct() {
                 if ($uriObj !== null) {
                     $mdArr = $uriObj->getMiddleware();
 
-                    for ($x = count($mdArr) - 1 ; $x > 0  ; $x--) {
+                    for ($x = count($mdArr) - 1 ; $x >= 0  ; $x--) {
                         $mdArr[$x]->afterSend(self::getRequest(), self::getResponse());
                     }
                 }
@@ -175,7 +175,7 @@ private function __construct() {
             if ($uriObj !== null) {
                 $mdArr = $uriObj->getMiddleware();
 
-                for ($x = count($mdArr) - 1 ; $x > 0  ; $x--) {
+                for ($x = count($mdArr) - 1 ; $x >= 0  ; $x--) {
                     $mdArr[$x]->after(self::getRequest(), self::getResponse());
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ private function __construct() {`
`164`	`164`	`if ($uriObj !== null) {`
`165`	`165`	`$mdArr = $uriObj->getMiddleware();`
`166`	`166`
`167`		`- for ($x = count($mdArr) - 1 ; $x > 0 ; $x--) {`
	`167`	`+ for ($x = count($mdArr) - 1 ; $x >= 0 ; $x--) {`
`168`	`168`	`$mdArr[$x]->afterSend(self::getRequest(), self::getResponse());`
`169`	`169`	`}`
`170`	`170`	`}`
`@@ -175,7 +175,7 @@ private function __construct() {`
`175`	`175`	`if ($uriObj !== null) {`
`176`	`176`	`$mdArr = $uriObj->getMiddleware();`
`177`	`177`
`178`		`- for ($x = count($mdArr) - 1 ; $x > 0 ; $x--) {`
	`178`	`+ for ($x = count($mdArr) - 1 ; $x >= 0 ; $x--) {`
`179`	`179`	`$mdArr[$x]->after(self::getRequest(), self::getResponse());`
`180`	`180`	`}`
`181`	`181`	`}`