Skip to content

Commit b982bd6

Browse files
author
Ibrahim BinAlshikh
committed
fix(test): make testRegisterDuplicate self-contained
Register the test theme explicitly instead of relying on pre-registered themes from bootstrap. Fixes skip in CI.
1 parent ba5502b commit b982bd6

1 file changed

Lines changed: 4 additions & 7 deletions

File tree

tests/WebFiori/Framework/Tests/Theme/ThemeTest.php

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -155,14 +155,11 @@ public function testRegisterNonThemeClass() {
155155
* @test
156156
*/
157157
public function testRegisterDuplicate() {
158-
$themes = ThemeManager::getRegisteredThemes();
159-
if (count($themes) > 0) {
160-
$firstTheme = array_values($themes)[0];
161-
$this->expectException(\WebFiori\Framework\Exceptions\NoSuchThemeException::class);
162-
ThemeManager::register($firstTheme);
163-
} else {
164-
$this->markTestSkipped('No themes registered');
158+
if (!ThemeManager::isThemeRegistered('New Super Theme')) {
159+
ThemeManager::register(new NewFTestTheme());
165160
}
161+
$this->expectException(\WebFiori\Framework\Exceptions\NoSuchThemeException::class);
162+
ThemeManager::register(new NewFTestTheme());
166163
}
167164
/**
168165
* @test

0 commit comments

Comments
 (0)