Conversation
…n StartSessionMiddleware Response::addHeader() is an instance method, not static. The static call silently fails in PHP 8.x (caught by the Error handler), so the session Set-Cookie header is never added to the response. Fixes #297
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
============================================
- Coverage 74.88% 74.84% -0.05%
Complexity 2974 2974
============================================
Files 97 97
Lines 9509 9509
============================================
- Hits 7121 7117 -4
- Misses 2388 2392 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
StartSessionMiddleware::after()callingResponse::addHeader()statically instead of using the$responseinstance parameter, which caused session cookies to never be sent.Motivation
addHeader()is an instance method onResponse. The static call fails silently in PHP 8.x because thecatch (Error $exc)block swallows the error. This means session cookies are never set, breaking session-based authentication. Fixes #297.Changes
Response::addHeader('set-cookie', $headerVal)to$response->addHeader('set-cookie', $headerVal)inStartSessionMiddleware::after()How to Test / Verify
start-sessionmiddleware to a route and verify theSet-Cookieheader appears in the responseBreaking Changes and Migration Steps
None
Checklist
Related issues
Closes #297