Conversation
…dedWebServicesManager - Pass null as first argument to parent::__construct() since WebServicesManager expects ?Request as first parameter, not string. - Use $this->getRequest()->getMethod() instead of static Request::getMethod() which is not a static method. Fixes #296
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=========================================
Coverage 74.89% 74.89%
Complexity 2976 2976
=========================================
Files 97 97
Lines 9511 9511
=========================================
Hits 7123 7123
Misses 2388 2388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Fix two issues in
ExtendedWebServicesManagerthat made the class unusable with the currentwebfiori/httppackage.Motivation
ExtendedWebServicesManagercrashes on instantiation due to passing the version string as the$requestparameter to the parent constructor, and callingRequest::getMethod()statically when it is an instance method. Fixes #296.Changes
parent::__construct($version)toparent::__construct(null, $version)to matchWebServicesManager::__construct(?Request $request, string $version)signatureRequest::getMethod()to$this->getRequest()->getMethod()sincegetMethod()is not staticHow to Test / Verify
ExtendedWebServicesManager, register it as an API route, and send a requestBreaking Changes and Migration Steps
None
Checklist
Related issues
Closes #296