Refactor MongoHeuristicsCalculator: extract computeDistanceDocuments method for handling document calculations, rename method for better clarity, and update related tests.

Author: jgaleotti

client-java/controller/src/main/java/org/evomaster/client/java/controller/internal/db/mongo/MongoHandler.java

@@ -144,32 +144,16 @@ private MongoDistanceWithMetrics computeFindDistance(MongoFindCommand info) {
         String databaseName = info.getDatabaseName();
         String collectionName = info.getCollectionName();
 
-        Object collection = getCollection(databaseName,collectionName);
+        Object collection = getCollection(databaseName, collectionName);
         Iterable<?> documents = getDocuments(collection);
         boolean collectionIsEmpty = !documents.iterator().hasNext();
 
         if (collectionIsEmpty) {
             emptyCollections.add(new MongoOperation(info.getCollectionName(), info.getQuery(), info.getDatabaseName(), info.getDocumentsType()));
         }
 
-        double min = Double.MAX_VALUE;
-        int numberOfEvaluatedDocuments = 0;
-        for (Object doc : documents) {
-            numberOfEvaluatedDocuments += 1;
-            double findDistance;
-            try {
-                findDistance = calculator.computeDistance(info.getQuery(), doc);
-            } catch (Exception ex) {
-                SimpleLogger.uniqueWarn("Failed to compute find: " + info.getQuery() + " with data " + doc);
-                findDistance = Double.MAX_VALUE;
-            }
-            if (findDistance == 0) {
-                return new MongoDistanceWithMetrics(0, numberOfEvaluatedDocuments);
-            } else if (findDistance < min) {
-                min = findDistance;
-            }
-        }
-        return new MongoDistanceWithMetrics(min, numberOfEvaluatedDocuments);
+        MongoDistanceWithMetrics mongoDistanceWithMetrics = calculator.computeDistanceDocuments(info.getQuery(), documents); // to update the metrics
+        return mongoDistanceWithMetrics;
     }
 
     private Object getCollection(String databaseName, String collectionName) {

client-java/controller/src/main/java/org/evomaster/client/java/controller/mongo/MongoHeuristicsCalculator.java

@@ -1,10 +1,12 @@
 package org.evomaster.client.java.controller.mongo;
 
+import org.evomaster.client.java.controller.internal.db.mongo.MongoDistanceWithMetrics;
 import org.evomaster.client.java.controller.mongo.operations.*;
 import org.evomaster.client.java.controller.mongo.operations.synthetic.*;
 import org.evomaster.client.java.distance.heuristics.DistanceHelper;
 import org.evomaster.client.java.distance.heuristics.TruthnessUtils;
 import org.evomaster.client.java.sql.internal.TaintHandler;
+import org.evomaster.client.java.utils.SimpleLogger;
 
 import static org.evomaster.client.java.controller.mongo.utils.BsonHelper.*;
 import static java.lang.Math.abs;
@@ -27,14 +29,37 @@ public MongoHeuristicsCalculator(TaintHandler taintHandler) {
         this.taintHandler = taintHandler;
     }
 
+
+    public MongoDistanceWithMetrics computeDistanceDocuments(Object queryDocument, Iterable<?> documents) {
+        double min = Double.MAX_VALUE;
+        int numberOfEvaluatedDocuments = 0;
+        for (Object doc : documents) {
+            numberOfEvaluatedDocuments += 1;
+            double findDistance;
+            try {
+                findDistance = this.computeHeuristicDocument(queryDocument, doc);
+            } catch (Exception ex) {
+                SimpleLogger.uniqueWarn("Failed to compute find: " + queryDocument + " with data " + doc);
+                findDistance = Double.MAX_VALUE;
+            }
+            if (findDistance == 0) {
+                return new MongoDistanceWithMetrics(0, numberOfEvaluatedDocuments);
+            } else if (findDistance < min) {
+                min = findDistance;
+            }
+        }
+        return new MongoDistanceWithMetrics(min, numberOfEvaluatedDocuments);
+
+    }
+
     /**
      * Compute a "branch" distance heuristics.
      *
      * @param query the QUERY clause which we want to resolve as true
      * @param doc   a document in the database for which we want to calculate the distance
      * @return a branch distance, where 0 means that the document would make the QUERY resolve as true
      */
-    public double computeDistance(Object query, Object doc) {
+    double computeHeuristicDocument(Object query, Object doc) {
         QueryOperation operation = getOperation(query);
         return computeHeuristicQueryOperation(operation, doc);
     }
@@ -201,9 +226,9 @@ private double calculateDistanceForInvertedAll(InvertedAllOperation<?> operation
         }
     }
 
-    private double computeHeuristic(SizeOperation operation, Object doc) {
+    private double computeHeuristic(SizeOperation operation, Object bsonDocument) {
         Integer expectedSize = operation.getValue();
-        Object actualValue = getValue(doc, operation.getFieldName());
+        Object actualValue = getValue(bsonDocument, operation.getFieldName());
 
         if (actualValue instanceof List<?>) {
             Integer actualSize = ((List<?>) actualValue).size();

client-java/controller/src/test/java/org/evomaster/client/java/controller/internal/db/mongo/MongoHandlerTest.java

@@ -3,6 +3,7 @@
 import com.mongodb.client.*;
 import org.bson.Document;
 import org.bson.conversions.Bson;
+import org.evomaster.client.java.controller.mongo.MongoHeuristicsCalculatorTest;
 import org.evomaster.client.java.instrumentation.MongoFindCommand;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;