investigating GA deadlock

Author: arcuri82

core-tests/integration-tests/core-it/src/test/kotlin/org/evomaster/core/problem/rest/SamplerVerifierTest.kt

@@ -22,6 +22,7 @@ import org.evomaster.core.remote.SutProblemException
 import org.evomaster.core.remote.service.RemoteController
 import org.evomaster.core.search.Individual
 import org.evomaster.core.search.gene.Gene
+import org.evomaster.core.search.gene.collection.EnumGene
 import org.junit.jupiter.api.*
 import org.junit.jupiter.api.Assertions.assertTrue
 import java.io.File
@@ -43,7 +44,7 @@ class SamplerVerifierTest {
     fun debugIssue(): Collection<DynamicTest>{
         val tests = sampleFromSchemasAndCheckInvariants(
             //NOTE: can replace with a folder to debug
-            "./src/test/resources/APIs_guru/asuarez.dev/searchly/1.0",
+            "./src/test/resources/APIs_guru/asana.com/1.0",
             "APIs_guru",
             false)
         assertTrue(tests.isNotEmpty())
@@ -134,6 +135,9 @@ class SamplerVerifierTest {
                     so we had to remove it
                  */
                 //System.gc()
+
+                EnumGene.cleanCache() //due to this, these tests cannot be run in parallel
+
                 println("RUNNING: $it") // Surefire sucks at providing info for @TestFactory
                 assertTimeoutPreemptively(Duration.ofSeconds(timeout), it) {
                     runInvariantCheck(it, 100, blackBox)

core/src/main/kotlin/org/evomaster/core/search/gene/collection/EnumGene.kt

@@ -55,6 +55,14 @@ class EnumGene<T : Comparable<T>>(
 
         private val log: Logger = LoggerFactory.getLogger(EnumGene::class.java)
 
+        /**
+         * This was potential issue in IT where we parse thousands of specs...
+         */
+        fun cleanCache(){
+            synchronized(cache){
+                cache.clear()
+            }
+        }
     }
 
     val values: List<T>
@@ -83,23 +91,23 @@ class EnumGene<T : Comparable<T>>(
             val list = elements
                 .toList() // need ordering to specify index of selection, so Set would not do
                 .map { if (it is String) it.intern() as T else it } //if strings, make sure to intern them
-                .sorted() //FIXME replace. only for debugging
-//                .run {
-//                    if(valueNames == null){
-//                        sorted() // sort, to make meaningful list comparisons, but only if examples are not named.
-//                                 // otherwise we lose vector alignment
-//                    } else {
-//                        this
-//                    }
-//                }
+                .run {
+                    if(valueNames == null){
+                        sorted() // sort, to make meaningful list comparisons, but only if examples are not named.
+                                 // otherwise we lose vector alignment
+                    } else {
+                        this
+                    }
+                }
 
             /*
                we need to make sure that, if we are adding a list that has content equal to
                an already present list in the cache, we only use this latter
              */
             synchronized(cache) {
-                values = if (cache.contains(list)) {
-                    cache.find { it == list }!! as List<T> // equality based on content, not reference
+                val x = cache.find { it == list } // equality based on content, not reference
+                values = if (x != null) {
+                    x as List<T>
                 } else {
                     cache.add(list)
                     list