Merge pull request #1592 from WebFuzzing/bugs-in-db

Bugs in db

Author: arcuri82

client-java/sql/src/main/java/org/evomaster/client/java/sql/internal/SqlNameContext.java

@@ -144,9 +144,8 @@ public void visit(Table table) {
 
                 @Override
                 public void visit(ParenthesedSelect selectBody) {
-                    PlainSelect plainSelect = selectBody.getPlainSelect();
-                    SqlNameContext subContext = new SqlNameContext(plainSelect);
-                    tableAliases.putAll(subContext.tableAliases);
+                    names.add(UNNAMED_TABLE);
+                    handleAlias(tableAliases, selectBody);
                 }
 
                 @Override
@@ -240,7 +239,7 @@ public void visit(Table table) {
 
         @Override
         public void visit(ParenthesedSelect selectBody) {
-            handleAlias(aliases, selectBody.getPlainSelect());
+            handleAlias(aliases, selectBody);
         }
 
         @Override
@@ -262,8 +261,13 @@ public void visit(ParenthesedFromItem aThis) {
     }
 
 
-    private static void handleAlias(Map<String, String> aliases, PlainSelect plainSelect) {
-        Alias alias = plainSelect.getFromItem().getAlias();
+    private static void handleAlias(Map<String, String> aliases, ParenthesedSelect select) {
+        /*
+            The alias belongs to the parenthesized FROM item itself. Do not read
+            it from the inner select, as UNION/INTERSECT/EXCEPT subqueries are
+            represented by JSqlParser as SetOperationList, not PlainSelect.
+         */
+        Alias alias = select.getAlias();
         if (alias != null) {
             String aliasName = alias.getName();
             if (aliasName != null) {

client-java/sql/src/test/java/org/evomaster/client/java/sql/internal/SqlNameContextTest.java

@@ -0,0 +1,31 @@
+package org.evomaster.client.java.sql.internal;
+
+import net.sf.jsqlparser.schema.Column;
+import net.sf.jsqlparser.schema.Table;
+import net.sf.jsqlparser.statement.Statement;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+public class SqlNameContextTest {
+
+    @Test
+    public void handlesAliasOnParenthesizedUnionSubquery() {
+        String sql = "SELECT derived.id\n" +
+                "FROM (\n" +
+                "    SELECT id FROM constraint_requires\n" +
+                "    UNION ALL\n" +
+                "    SELECT id FROM constraint_excludes\n" +
+                ") derived\n" +
+                "WHERE derived.id = 2";
+
+        Statement statement = SqlParserUtils.parseSqlCommand(sql);
+        SqlNameContext context = assertDoesNotThrow(() -> new SqlNameContext(statement));
+
+        assertEquals(
+                SqlNameContext.UNNAMED_TABLE,
+                context.getFullyQualifiedTableName(new Column(new Table("derived"), "id"))
+        );
+    }
+}