Merge pull request #1618 from WebFuzzing/status-oracle-ramaining

Status oracle ramaining

Author: arcuri82

core-tests/e2e-tests/spring/spring-rest-openapi-v3/src/main/kotlin/com/foo/rest/examples/spring/openapi/v3/statusoracle/StatusOracleRest.kt

@@ -52,6 +52,11 @@ private class StatisticsRest {
         return ResponseEntity.status(204).body("Hello")
     }
 
+    @GetMapping(path = ["/no-205-if-content"])
+    fun no205IfContent(): ResponseEntity<String> {
+        return ResponseEntity.status(205).body("Hello")
+    }
+
     @PostMapping(path = ["/no-413-if-no-payload"])
     fun no413IfNoPayload() : ResponseEntity<String> {
         return ResponseEntity.status(413).build()
@@ -95,4 +100,9 @@ private class StatisticsRest {
     fun no501IfImplemented(): ResponseEntity<String>{
         return ResponseEntity.status(501).build()
     }
+
+    @GetMapping(path = ["/no-426-if-no-upgrade"])
+    fun no426IfNoUpgrade(): ResponseEntity<String>{
+        return ResponseEntity.status(426).build()
+    }
 }

core-tests/e2e-tests/spring/spring-rest-openapi-v3/src/test/kotlin/org/evomaster/e2etests/spring/openapi/v3/statusoracle/StatusOracleEMTest.kt

@@ -58,6 +58,11 @@ class StatusOracleEMTest : SpringTestBase(){
             //assertHasAtLeastOne(solution, HttpVerb.GET, 204, "/api/statusoracle/no-204-if-content", "Hello")
             //assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_204_IF_CONTENT })
 
+            //205
+            //Same issue as 204
+            //assertHasAtLeastOne(solution, HttpVerb.GET, 205, "/api/statusoracle/no-205-if-content", "Hello")
+            //assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_205_IF_CONTENT })
+
             //304
             assertHasAtLeastOne(solution, HttpVerb.POST, 304, "/api/statusoracle/no-304-if-no-get-or-head", null)
             assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_304_IF_NO_GET_OR_HEAD })
@@ -83,6 +88,10 @@ class StatusOracleEMTest : SpringTestBase(){
             assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_413_IF_NO_PAYLOAD })
             assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_415_IF_NO_PAYLOAD })
 
+            //426
+            assertHasAtLeastOne(solution, HttpVerb.GET, 426, "/api/statusoracle/no-426-if-no-upgrade", null)
+            assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_426_IF_NO_UPGRADE })
+
             //501
             assertHasAtLeastOne(solution, HttpVerb.GET, 501, "/api/statusoracle/no-501-if-implemented", null)
             assertTrue(faultsCategories.any { it == ExperimentalFaultCategory.HTTP_STATUS_NO_501_IF_IMPLEMENTED })

core/src/main/kotlin/org/evomaster/core/problem/enterprise/ExperimentalFaultCategory.kt

@@ -51,10 +51,11 @@ enum class ExperimentalFaultCategory(
     HTTP_STATUS_NO_403_IF_NO_401(958, "no-403-if-no-401", "403WhenNo401",  "TODO"),
     HTTP_STATUS_HAS_406_IF_ACCEPT(959, "has-406-if-accept", "406WhenValid",  "TODO"),
     HTTP_STATUS_NO_304_IF_NO_GET_OR_HEAD(960, "no-304-if-no-get-or-head", "", "TODO"),
-    HTTP_STATUS_NO_401_IF_NO_WWW_AUTHENTICATE(961, "no-401-if-no-www-authenticate", "", "TODO"),
+    HTTP_STATUS_NO_401_IF_NO_WWW_AUTHENTICATE(961, "no-401-if-no-authenticate", "", "TODO"),
     HTTP_STATUS_NO_405_IF_NO_ALLOW(962, "no-405-if-no-allow", "", "TODO"),
     HTTP_STATUS_NO_501_IF_IMPLEMENTED(963, "no-501-if-implemented", "", "TODO"),
-
+    HTTP_STATUS_NO_205_IF_CONTENT(964,"no-205-if-content","", "TODO"),
+    HTTP_STATUS_NO_426_IF_NO_UPGRADE(965,"no-426-if-no-upgrade","", "TODO"),
 
     //3xx: GraphQL
     GQL_ERROR_FIELD(920, "Error Field", "returnedErrors",

core/src/main/kotlin/org/evomaster/core/problem/rest/oracle/HttpStatusOracle.kt

@@ -24,6 +24,7 @@ import org.evomaster.core.problem.rest.schema.SchemaUtils
  * no-201-if-get
  * no-201-if-patch
  * no-204-if-content
+ * no-205-if-content
  * no-304-if-no-get-or-head
  * no-401-if-no-www-authenticate
  * no-405-if-no-allow
@@ -32,6 +33,7 @@ import org.evomaster.core.problem.rest.schema.SchemaUtils
  * no-401-if-no-auth (schema)
  * no-403-if-no-401 (schema)
  * has-406-if-accept (schema)
+ * no-426-if-no-upgrade
  * no-501-if-implemented
  *
  *
@@ -64,10 +66,14 @@ object HttpStatusOracle {
             }
         }
 
-        if(status == 204 && verb == HttpVerb.GET && result.hasBody()){
+        if(status == 204  && result.hasBody()){
             faults.add(ExperimentalFaultCategory.HTTP_STATUS_NO_204_IF_CONTENT)
         }
 
+        if(status == 205  && result.hasBody()){
+            faults.add(ExperimentalFaultCategory.HTTP_STATUS_NO_205_IF_CONTENT)
+        }
+
         val bodyParam = call.parameters.filterIsInstance<BodyParam>()
             .firstOrNull()
 
@@ -105,6 +111,10 @@ object HttpStatusOracle {
             faults.add(ExperimentalFaultCategory.HTTP_STATUS_NO_415_IF_NO_PAYLOAD)
         }
 
+        if(status == 426 && result.getHeader("upgrade").isNullOrEmpty()){
+            faults.add(ExperimentalFaultCategory.HTTP_STATUS_NO_426_IF_NO_UPGRADE)
+        }
+
         if(status == 501){
             faults.add(ExperimentalFaultCategory.HTTP_STATUS_NO_501_IF_IMPLEMENTED)
         }