Fix handling of missing columns in rows

Author: gonzalotguerrero

client-java/controller/src/main/java/org/evomaster/client/java/controller/cassandra/calculator/CassandraOperationEvaluator.java

@@ -113,6 +113,9 @@ private Truthness evaluateLessThanEquals(LessThanEqualsOperation<?> op, Cassandr
 
     private Truthness evaluateIn(InOperation op, CassandraRow candidateRow) {
         Object rowValue = candidateRow.getValue(op.getColumnName());
+        if (rowValue == null) {
+            return FALSE_TRUTHNESS;
+        }
 
         return any(rowValue, op.getValues());
     }
@@ -121,17 +124,17 @@ private Truthness evaluateContains(ContainsOperation<?> op, CassandraRow candida
         Object rawCol = candidateRow.getValue(op.getColumnName());
         if (rawCol == null) {
             return FALSE_TRUTHNESS;
-        } else {
-            return any(op.getValue(), toElementList(rawCol));
         }
+
+        return any(op.getValue(), toElementList(rawCol));
     }
 
     private Truthness evaluateContainsKey(ContainsKeyOperation<?> op, CassandraRow candidateRow) {
         Object rawCol = candidateRow.getValue(op.getColumnName());
         if (rawCol == null) {
             return FALSE_TRUTHNESS;
         } else if (!(rawCol instanceof Map<?, ?>)) {
-            return FALSE_TRUTHNESS;
+            throw new IllegalArgumentException("CONTAINS KEY is only supported on map columns, got: " + rawCol.getClass().getName());
         } else {
             List<?> keys = new ArrayList<>(((Map<?, ?>) rawCol).keySet());
             return any(op.getValue(), keys);
@@ -142,10 +145,8 @@ private Truthness evaluateComparison(ComparisonOperation<?> op, CassandraRow can
         Object rowValue   = candidateRow.getValue(op.getColumnName());
         Object queryValue = op.getValue();
 
-        if (rowValue == null && queryValue == null) {
+        if (rowValue == null) {
             return FALSE_TRUTHNESS;
-        } else if (rowValue == null || queryValue == null) {
-            return FALSE_TRUTHNESS_BETTER;
         } else {
             Truthness typeResult = compareByType(rowValue, queryValue, type);
             if (typeResult.isTrue()) {
@@ -385,18 +386,12 @@ private Truthness any(Object value, List<?> candidates) {
     }
 
     private Truthness evaluateEquals(Object a, Object b) {
-        if (a == null && b == null) {
-            return FALSE_TRUTHNESS;
-        } else if (a == null || b == null) {
-            return FALSE_TRUTHNESS_BETTER;
-        } else {
-            Truthness raw = compareByType(a, b, ComparisonType.EQUALS);
-            if (raw.isTrue()) {
-                return raw;
-            } else {
-                return TruthnessUtils.buildScaledTruthness(C_BETTER, raw.getOfTrue());
-            }
+        Truthness unscaledTruthness = compareByType(a, b, ComparisonType.EQUALS);
+        if (unscaledTruthness.isTrue()) {
+            return unscaledTruthness;
         }
+
+        return TruthnessUtils.buildScaledTruthness(C_BETTER, unscaledTruthness.getOfTrue());
     }
 
     private static List<?> toElementList(Object collection) {