-
Notifications
You must be signed in to change notification settings - Fork 114
Testify/playwright #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkugelstad
wants to merge
23
commits into
master
Choose a base branch
from
testify/playwright
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Testify/playwright #1552
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9e42dde
New branch and updated output format
43c2d8f
Add initial Playwright output support
FredRaw 444d280
Add support for Playwright.
e780704
Fix header handling, send body, and test initialization for Playwright
a345275
Fix duplicate playwright entry
c5842f5
Add support for Playwright
cbf837b
Add support for Playwright
2ac346d
Add support for Playwright
1f0563b
Rewrite of existing support for Playwright, add Playwright support fo…
4969fb6
Add lombok
a3b7898
Merge branch 'master' into testify/playwright
8234fc3
added possible fixes for playwright code
FredRaw 158e195
Add Playwright library to core-tests/e2e-tests/spring/spring-rest-bb/…
42c8bc7
Merge branch 'master' into testify/playwright
e666fb6
updated release.yml to include changes from master branch
FredRaw b8dc0a3
re-introduced if(nody.isNotBlank()) test to avoid failure of testInAc…
FredRaw 188b96a
BlackBoxUtils.kt: Add base location and relative path for Playwright …
cd595a8
Merge branch 'master' into testify/playwright
ce12797
All changes only made to playwright code. Will hopefully fix BB test …
b8faf64
Merge branch 'master' into testify/playwright
21290a0
Merge branch 'master' into testify/playwright
0a9d352
Merge branch 'master' into testify/playwright
arcuri82 baec931
Improve Playwright output format and refactor E2E test utils post PR …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
core-tests/e2e-tests/spring/spring-rest-bb/javascript/package-lock.json
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
core-tests/e2e-tests/spring/spring-rest-bb/javascript/playwright.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| const { defineConfig } = require('@playwright/test'); | ||
|
|
||
| module.exports = defineConfig({ | ||
| testDir: './generated', | ||
| testMatch: /.*[tT]est\.js/, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code here seems duplicated from
runNpmTests(). if indeed this function is needed (see previous comment) than should refactor (eg a single function with possible more parameters) to avoid code duplicationThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment