Java regex quote (\Q...\E) bug fix#1644
Merged
Merged
Conversation
… and gitignore for default recognizer location.
jgaleotti
approved these changes
Jul 20, 2026
arcuri82
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug with java regex quoting.
Currently, when multiple quotes appear in one regex we took the first
\Qand matched it with the last\E, ignoring the rest, this results in regex like^(\\Q81\\E(x|X)(a|A)\\Q3\\E(p|P)(x|X)(d|D))$sampling things like81\\Exa\\Q3\\Epxdinstead of81xa3pxd. We also needed to explicitly allow all lexer tokens on thequoteCharparser rule before.This PR solves both, by splitting the
RegexJava.g4combined grammar intoRegexJavaParser.g4(parser grammar) andRegexJavaLexer.g4(lexer grammar) we can now use lexer modes to define separate set of lexer tokens depending on the context. This lets us solve the two problems.Note: the diff might look large as the combined file got deleted and two new files appeared but there where only some minor changes to the actual grammar regarding quoting.